refactor(filter): use PolarInput#810
Conversation
|
c976070 to
77acbd9
Compare
The differentiation between the interface for layout standard and nineRegions including the components KernCheckbox and KernBlockButtonCheckbox has been removed. This change includes a refactor of the store and its logic to work without much overhead together with PolarInput.
The differentiation between the interface for layout standard and nineRegions including the components KernRadioGroup and KernBlockButtonRadioGroup has been removed.
77acbd9 to
226a455
Compare
oeninghe-dataport
left a comment
There was a problem hiding this comment.
Without looking into the code, it's stated in #779:
The standard layout's block-button styling is applied via CSS (e.g. a class on the group or scoped styles)
However, the standard layout is not intact anymore but looks like the nineRegions layout.
Before:
After:
Please update your PR such that the styling before is still working.
After consulting with UX, I've adjusted the issue to scrap the block-button styling as the radios and checkboxes should not behave the same visually as one would not properly discern the possibility to select multiple elements with the checkboxes or is confused as one would only be able to select one element with the radio buttons. |


Summary
Replaces layout-conditional checkbox/radio components (
KernBlockButtonCheckbox,KernCheckbox,KernBlockButtonRadioGroup,KernRadioGroup) infilterwith the unifiedPolarInputcomponent (as proposed in #734).Simplifies
categorystatefromRecord<string, boolean>tostring[]and introduces a reactive getter/setter-basedselectionmodel on categories for directv-modelbinding and to get rid ofgetCategoryStatusandsetCategoryStatus.Also added some small changes to
PolarInputandPolarInputGroup.Instructions for local reproduction and review
npm run snowboxfilter1xxmulti-value category entry correctly selects/deselects with its individual values (100,101,102)Additional information
I intend to update the implementation in
src/plugins/filter/stores/category.ts(a) andsrc/plugins/filter/stores/time.ts(#811) as well.For (a): Currently, if a user switches between two layers, the filter state of the the previous layer is reset. This is odd from a usability perspective. If you agree, I'll change this in a separate PR so that the state stays even if the layer switches.
Tickets
Resolves #779