Skip to content

Pins: Consider external updates and allow ignoring change sources#768

Open
oeninghe-dataport wants to merge 4 commits into
nextfrom
fix/766-pins-consider-external-updates
Open

Pins: Consider external updates and allow ignoring change sources#768
oeninghe-dataport wants to merge 4 commits into
nextfrom
fix/766-pins-consider-external-updates

Conversation

@oeninghe-dataport

Copy link
Copy Markdown
Collaborator

Summary

Consider external updates (#766) and allow ignoring change sources (#655).

Instructions for local reproduction and review

See #766 and #655

Relevant tickets, issues, et cetera

Fixes #766
Fixes #655

As we use the vite plugin enriched console, we do not specify the source
of a log message manually.
This ignores changes originated from addressSearch to the pins
coordinate for the reverseGeocoder in the snowbox.

Fixes #655
@oeninghe-dataport oeninghe-dataport added this to the POLAR@3 milestone Jun 3, 2026
@oeninghe-dataport oeninghe-dataport self-assigned this Jun 3, 2026
@oeninghe-dataport oeninghe-dataport requested a review from a team June 3, 2026 16:34
@oeninghe-dataport oeninghe-dataport added the bug Something isn't working label Jun 3, 2026
@dopenguin

Copy link
Copy Markdown
Member

The target should probably be next and not main, @oeninghe-dataport 😄

@warm-coolguy warm-coolguy changed the base branch from main to next June 22, 2026 09:22
@warm-coolguy

Copy link
Copy Markdown
Member

The target should probably be next and not main, @oeninghe-dataport 😄

Fixed.

sailormoonmeme_6358795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes to pins coordinate are not reflected in the map AddressSearch, Pins, ReverseGeocoder: Reference hell

3 participants