Skip to content

Enforce unified import syntax#750

Open
oeninghe-dataport wants to merge 7 commits into
nextfrom
vue3/improve-import-lint
Open

Enforce unified import syntax#750
oeninghe-dataport wants to merge 7 commits into
nextfrom
vue3/improve-import-lint

Conversation

@oeninghe-dataport

@oeninghe-dataport oeninghe-dataport commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

We introduce two new linting rules that ensure:

  1. Type imports need to be specified as type imports.
  2. The optional .ts ending for imports is omitted.
  3. Within the same context (that means: either core, a lib module or a plugin), we use relative imports. Within different contexts, we use @/...-style absolute imports.

Instructions for local reproduction and review

No visible changes, just review the code.

Relevant tickets, issues, et cetera

Blocked by #748

Review process

This should be approved by @warm-coolguy and @dopenguin.
If necessary, we'll discuss this in the weekly.

@oeninghe-dataport oeninghe-dataport added this to the POLAR@3 milestone Jun 1, 2026
@oeninghe-dataport oeninghe-dataport self-assigned this Jun 1, 2026
@oeninghe-dataport oeninghe-dataport added the refactor Refactoring of previous code label Jun 1, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://Dataport.github.io/polar/pr-preview/pr-750/

Built to branch gh-pages at 2026-07-03 07:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dopenguin dopenguin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread eslintRules/import-style.ts
Comment thread eslint.config.ts Outdated
@oeninghe-dataport

Copy link
Copy Markdown
Collaborator Author

🏓 @dopenguin

@dopenguin

Copy link
Copy Markdown
Member

🏓 @dopenguin

🏓 @oeninghe-dataport

@oeninghe-dataport

Copy link
Copy Markdown
Collaborator Author

🏓 @dopenguin

@dopenguin

Copy link
Copy Markdown
Member

🏓 @dopenguin

Please also rebase the PR

🏓 @oeninghe-dataport

@oeninghe-dataport oeninghe-dataport force-pushed the vue3/improve-import-lint branch from 27fb915 to 7087288 Compare July 2, 2026 14:28
@oeninghe-dataport oeninghe-dataport requested a review from a team July 2, 2026 14:28

@dopenguin dopenguin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/plugins/iconMenu/types.ts Outdated
Comment thread src/core/types/locales.ts Outdated
@oeninghe-dataport oeninghe-dataport force-pushed the vue3/improve-import-lint branch from a44b496 to 6b689f1 Compare July 2, 2026 16:53

@dopenguin dopenguin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/core/types/plugin.ts
Comment thread eslintRules/import-style.ts Outdated

@dopenguin dopenguin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1/2 approves given, @warm-coolguy, you're next!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring of previous code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants