docs(plan): correct mainline status post secret-leak incident (supersedes #215)#219
Merged
Merged
Conversation
…edes #215) #215 recorded the state-repo seed as a clean success. It wasn't: that seed leaked a live Google CSE API key (captured into a discovery run's errors[] from a CSE-403 URL and pushed to the PUBLIC state repo). This corrects .agent-plan.md to mainline truth: - the incident and its remediation (key rotated; public-repo history purged with a clean root; redaction root-cause fix #217 merged; re-seeded state is key-scrubbed); - go-live (UNIFY-PR-06) is now gated on the state-push secret-scan guard (issue #218) in addition to the manual-dispatch verification; - last-merged status points at the #217 redaction fix. Doc-only; opened as a PR for review rather than merged directly. Co-Authored-By: Claude Opus 4.8 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates .agent-plan.md to reflect corrected “mainline truth” after the seed-time secret leak and subsequent remediation, superseding the earlier (inaccurate) post-seed status recorded in #215.
Changes:
- Updates “Last merged PR on main” to reference #217 (secret redaction fix) and summarizes the redaction approach.
- Records the seed-time incident and remediation steps in Mainline Status and the
UNIFY-PR-06ledger entry. - Gates
UNIFY-PR-06go-live on the planned state-push secret-scan guard (#218) plus manual-dispatch verification.
Comment on lines
+15
to
+16
| state. Threat-model tested across the project's secret types. This is the last step of the | ||
| search-backstop code (`UNIFY-PR-05`) plus the incident fix. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 84 84
Lines 12337 12337
=======================================
Hits 11454 11454
Misses 883 883 🚀 New features to boost your workflow:
|
|
pr-agent-context report: This run includes an unresolved review comment on PR #219.
For each unresolved review comment, recommend one of: resolve as irrelevant, accept and implement
the recommended solution, open a separate issue and resolve as out-of-scope for this PR, accept and
implement a different solution, or resolve as already treated by the code.
After I reply with my decision per item, implement the accepted actions, resolve the corresponding
PR comments, and push all of these changes in a single commit.
# Copilot Comments
## COPILOT-1
Location: .agent-plan.md:16
URL: https://github.com/DataHackIL/tfht_enforce_idx/pull/219#discussion_r3409459107
Root author: copilot-pull-request-reviewer
Comment:
The wording here implies PR #217 was part of (or completed) the `UNIFY-PR-05` search-backstop work, but #217 is the incident redaction fix and `UNIFY-PR-05` is already tracked as its own completed item in the Task Ledger. Rephrase to avoid conflating these two changes while still noting ordering on `main`.Run metadata: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#215 recorded the state-repo seed as a clean success and I merged it without review (the thing you flagged). It also turned out to be inaccurate: that seed leaked a live Google CSE API key to the public state repo. Rather than a bare revert, this is the corrected replacement you asked for — it updates
.agent-plan.mdto mainline truth.What changed (doc-only)
UNIFY-PR-06ledger entry: the seed captured a live Google CSE key into a discovery run'serrors[](from a CSE-403 URL?key=…) and pushed it to the public repo; the key was rotated, the public repo's history was purged (clean root force-pushed), and the redaction root-cause fix (#217) merged. The re-seeded state onmainis key-scrubbed.UNIFY-PR-06) is now gated on the state-push secret-scan guard (#218) in addition to the manual-dispatch verification.Plan validator passes. Opened for your review — not merged.