[python] Handle PEP 440 local prerelease versions#94
Merged
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 95f3556 | Docs | Datadog PR Page | Give us feedback! |
anmarchenko
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Normalizes Python package versions returned by
importlib.metadata.version("ddtrace")before ddtest's Python sanity check parses them.dd-trace-pycan publish PEP 440 prerelease/local versions like4.12.0rc1+g0e3e598. ddtest's internal version parser expects semver-style prerelease syntax, so this PR converts those Python forms to parser-compatible values such as4.12.0-rc1+g0e3e598while leaving normal versions like4.10.3unchanged.Motivation
When running the new Pytest/ddtest e2e flow from Shepherd against
dd-trace-py@main, ddtest failed during platform sanity checking before planning tests:That happened because the previous normalization handled
4.12.0rc1, but not the real source-build form with local metadata:4.12.0rc1+g....Additional Notes
The normalization stays in the Python platform layer instead of changing the shared version parser. This keeps the PEP 440 compatibility behavior scoped to Python package versions and avoids changing Ruby/JS/ddtest version semantics.
How to test the change?
Automated coverage was added for alpha, beta, rc, and local metadata cases, including the observed
4.12.0rc1+g0e3e598shape.Validated locally with: