Stop publishing armv7 IoT Agent packages - #55070
Draft
jszwedko wants to merge 4 commits into
Draft
Conversation
Make the armhf deb/rpm publish jobs manual-only as the first step in dropping armv7 support, while keeping build/packaging jobs intact so this is trivially revertible. Co-Authored-By: Claude Sonnet 5 <[email protected]>
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Co-Authored-By: Claude Sonnet 5 <[email protected]>
…dog-agent into jszwedko/drop-armv7-publish
Contributor
Gitlab CI Configuration ChangesModified Jobsdeploy_packages_iot_deb-armhf-7 deploy_packages_iot_deb-armhf-7:
before_script:
- ls $OMNIBUS_PACKAGE_DIR
- ls ${OMNIBUS_PACKAGE_DIR}/${ARTIFACT_NAME_PATTERN}
image: registry.ddbuild.io/ci/datadog-agent-buildimages/gitlab_agent_deploy$CI_IMAGE_GITLAB_AGENT_DEPLOY_SUFFIX:$CI_IMAGE_GITLAB_AGENT_DEPLOY
needs:
- iot_agent_deb-armhf
resource_group: deb_bucket
rules:
+ - allow_failure: true
- - if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
? ^
+ if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
? ^
+ when: manual
script:
- dd-pkg version
- dd-pkg upload "${OMNIBUS_PACKAGE_DIR}" ${DD_PKG_EXTRA_ARGS}
stage: deploy_packages
tags:
- arch:amd64
- specific:true
variables:
ARTIFACT_NAME_PATTERN: '*_7.*${PACKAGE_ARCH}.deb'
PACKAGE_ARCH: armhfdeploy_packages_iot_rpm-armhf-7 deploy_packages_iot_rpm-armhf-7:
before_script:
- ls $OMNIBUS_PACKAGE_DIR
- ls ${OMNIBUS_PACKAGE_DIR}/${ARTIFACT_NAME_PATTERN}
image: registry.ddbuild.io/ci/datadog-agent-buildimages/gitlab_agent_deploy$CI_IMAGE_GITLAB_AGENT_DEPLOY_SUFFIX:$CI_IMAGE_GITLAB_AGENT_DEPLOY
needs:
- iot_agent_rpm-armhf
resource_group: rpm_bucket
rules:
+ - allow_failure: true
- - if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
? ^
+ if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
? ^
+ when: manual
script:
- dd-pkg version
- dd-pkg upload "${OMNIBUS_PACKAGE_DIR}" ${DD_PKG_EXTRA_ARGS}
stage: deploy_packages
tags:
- arch:amd64
- specific:true
variables:
ARTIFACT_NAME_PATTERN: '*-7.*${PACKAGE_ARCH}.rpm'
PACKAGE_ARCH: armv7hlChanges Summary
ℹ️ Diff available in the job log. |
Contributor
Files inventory check summaryFile checks results against ancestor 9f2fd1cb: Results for datadog-agent_7.84.0~devel.git.273.2de2671.pipeline.131688729-1_amd64.deb:No change detected Results for datadog-iot-agent_7.84.0~devel.git.273.2de2671.pipeline.131688729-1_amd64.deb:No change detected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the two armv7 (armhf) IoT Agent package publish jobs manual-only instead of automatic on deploy pipelines:
deploy_packages_iot_deb-armhf-7(APT)deploy_packages_iot_rpm-armhf-7(YUM)Build, packaging, and quality-gate jobs for armv7 are left untouched.
Note that armv7 only applies to the IoT Agent flavor. There are no full Agent or Docker image builds for this architecture, so this is the entire publish surface.
Motivation
We're planning to drop armv7 support from the Agent. As a first, easily-reversible step, we want to stop shipping armv7 packages to customers while keeping all the build machinery in place, so we can quickly revert if we get customer complaints. We've already reached out to affected customers to collect their input.
The plan is to drop the scaffolding in a later release (likely 7.87.0).
Describe how you validated your changes
Ran
dda inv linter.gitlab-ci, which validates.gitlab-ci.ymland includes across 9 CI contexts (main branch push, release branch, tag, merge queue, deploy pipelines, etc.) — all passed.Additional Notes
Reverting is a one-line removal of the added
rules: !reference [.on_deploy_manual]override in each job.