[Backport 7.83.x] [CWS] Fix: handle activity dump endpoint host that already embeds a port

[kovagsm]

Backport of #54774 to 7.83.x.

What was broken in 7.83

This is a bug fix. CWS activity dump uploads to dual-shipped additional_endpoints whose host already includes a port (e.g. cws-intake.datadoghq.com.:443) fail. GetEndpointURL appended the port a second time, producing a malformed [host:port]:port authority that failed URL parsing, so every upload to that endpoint failed with an invalid port error.

In prod, CWS activity dumps were failing to reach the secondary (dual-ship) endpoint.

Fix

The host is now split before joining, so an embedded port is honored instead of duplicated. An explicitly configured port still wins, and bare IPv6 literals are untouched.

Automated testing

Test coverage is included in this backport (pkg/security/utils/endpoint_test.go), reproducing the exact prod host and asserting the resulting URL is accepted by http.NewRequest — the call that previously failed. Additional cases cover explicit-port precedence and IPv6 with an embedded port.

Cherry-pick

Cherry-picked cleanly (no conflicts) from d4251bf9b58f48d1c28070dd662a1ef6d001936f.

Made with Cursor

[github-actions]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: a9947ecc80

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor bcd2738a:

Results for datadog-agent_7.83.0~rc.3.git.9.a9947ec.pipeline.131648939-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.83.0~rc.3.git.9.a9947ec.pipeline.131648939-1_amd64.deb:

No change detected

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 477e6d56-6078-4fe5-a5dc-220bca6caf91

Baseline: bf99c21
Comparison: a9947ec
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+0.86	[+0.61, +1.11]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	+0.34	[+0.26, +0.41]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	+0.29	[+0.14, +0.44]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.28	[+0.16, +0.40]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.21	[+0.16, +0.25]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	+0.11	[-0.01, +0.23]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-0.09	[-0.95, +0.77]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	-0.46	[-0.57, -0.36]	1	Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	4 = 4	bounds checks dashboard
❌	quality_gate_idle	memory_usage	0/10	172.76MiB > 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	746.13KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	4 = 4	bounds checks dashboard
❌	quality_gate_idle_all_features	memory_usage	9/10	517.00MiB > 512MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
❌	quality_gate_logs	memory_usage	2/10	201.78MiB > 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	263.86MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	375.13 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	397.73MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	71.26MiB ≤ 75MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	28.43 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	325.04MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	60.65 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	305.46MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	22.14 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	312.80MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

• quality_gate_idle, bounds check memory_usage: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 2/10 replicas passed. Failed 8 which is > 0. Gate FAILED.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.