Revert ineffective "drop DWARF from Windows Go test binary links"

[rdesgroppes]

This reverts commit 078d86b (#54903).

Motivation

-w was measured inert against the failure it was meant to mitigate.

The OOM is in Go's own linker, not mingw ld: all 25 errno=1455 dumps in job 1951788199 sit in loadlib -> LoadSyms -> preloadSyms.

-w suppresses DwarfGenerateDebugSyms, which runs after loadlib, and it does not shrink the linker input either, because the compiler emits DWARF into the object files regardless (-dwarf defaults to true).

Describe how you validated your changes

Windows VM, 20 GB commit ceiling, GOMEMLIMIT=2560MiB, 3 reps each of:

go test -p 8 -race -cover -covermode=atomic ./cmd/...

without -w   2/3 OOM   peaks 16,581-17,299 MB
with -w      2/3 OOM   peaks 16,768-17,240 MB

Per-phase linker heap on Linux, -ldflags=-benchmark=mem, -race:

                Loadlib live   DwarfGenerateDebugSyms alloc
baseline            420.2 MB                       412.9 MB
-w                  420.5 MB                              0

Loadlib is unchanged to within 0.3 MB, which is why the OOM rate does not move.

Additional Notes

-w does cut peak link heap by 19 percent on Linux, 637 MB to 518 MB, and costs no diagnostics because pclntab is untouched.

That saving is real but sits on the wrong side of the failing phase.

Capping build concurrency is what addresses the OOM: -p 5 was 0/8 clean where -p 8 was 3/3 OOM, hence:

• incident-59224/incident-59369: cap tests_windows-x64 build parallelism at 4 #55054.

Measured on a 20 GB bare host over ./cmd/... without the python tag, so the ordering transfers but the absolute numbers are not CI's.

[aiuto]

This and #55044 seem very related.
You and @chouetz should work this out together.

[datadog-prod-us1-5]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 52.47% (+0.03%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8364f54 | Docs | View more details | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 3067dd1c:

Results for datadog-agent_7.84.0~devel.git.269.8364f54.pipeline.131636651-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.269.8364f54.pipeline.131636651-1_amd64.deb:

No change detected

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 348e2d31-4ea5-43fc-9cdc-3e0258d45513

Baseline: 83ec016
Comparison: 3b6d902
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+0.31	[+0.09, +0.53]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	+0.22	[+0.13, +0.30]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	+0.01	[-0.05, +0.06]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.00	[-0.04, +0.05]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.06	[-0.10, -0.03]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-0.08	[-0.95, +0.80]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.10	[-0.14, -0.07]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	-0.40	[-0.52, -0.27]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	172.21MiB ≤ 178MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	745.38KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	513.69MiB ≤ 538MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.14MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	19 ≤ 40	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	210.00MiB ≤ 229MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	263.43MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	386.48 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	20 ≤ 40	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	412.37MiB ≤ 439MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	71.36MiB ≤ 76MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	32.47 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	327.14MiB ≤ 335MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	67.23 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	303.74MiB ≤ 314MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	23.87 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	312.16MiB ≤ 343MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3067dd1
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	N/A	N/A → 760.347 → 764.600
✅	agent_deb_amd64_fips	N/A	N/A → 713.243 → 715.840
✅	agent_heroku_amd64	N/A	N/A → 312.522 → 319.080
✅	agent_rpm_amd64	N/A	N/A → 760.331 → 764.570
✅	agent_rpm_amd64_fips	N/A	N/A → 713.227 → 715.840
✅	agent_rpm_arm64	N/A	N/A → 736.130 → 737.130
✅	agent_rpm_arm64_fips	N/A	N/A → 692.351 → 693.820
✅	agent_suse_amd64	N/A	N/A → 760.331 → 764.570
✅	agent_suse_amd64_fips	N/A	N/A → 713.227 → 715.840
✅	agent_suse_arm64	N/A	N/A → 736.130 → 737.130
✅	agent_suse_arm64_fips	N/A	N/A → 692.351 → 693.820
✅	docker_agent_amd64	N/A	N/A → 818.986 → 820.140
✅	docker_agent_arm64	N/A	N/A → 819.868 → 820.890
✅	docker_agent_jmx_amd64	N/A	N/A → 1009.884 → 1010.900
✅	docker_agent_jmx_arm64	N/A	N/A → 999.418 → 1000.570
✅	docker_cluster_agent_amd64	N/A	N/A → 211.151 → 212.130
✅	docker_cluster_agent_arm64	N/A	N/A → 224.206 → 225.220
✅	docker_cws_instrumentation_amd64	N/A	N/A → 7.443 → 8.400
✅	docker_cws_instrumentation_arm64	N/A	N/A → 6.877 → 7.110
✅	docker_dogstatsd_amd64	N/A	N/A → 39.463 → 40.440
✅	docker_dogstatsd_arm64	N/A	N/A → 37.560 → 38.580
✅	docker_host_profiler_amd64	N/A	N/A → 305.792 → 317.700
✅	docker_host_profiler_arm64	N/A	N/A → 317.104 → 328.970
✅	dogstatsd_deb_amd64	N/A	N/A → 30.204 → 31.210
✅	dogstatsd_deb_arm64	N/A	N/A → 28.236 → 29.590
✅	dogstatsd_rpm_amd64	N/A	N/A → 30.204 → 31.210
✅	dogstatsd_suse_amd64	N/A	N/A → 30.204 → 31.210
✅	iot_agent_deb_amd64	N/A	N/A → 46.467 → 47.550
✅	iot_agent_deb_arm64	N/A	N/A → 43.128 → 44.220
✅	iot_agent_deb_armhf	N/A	N/A → 43.922 → 45.020
✅	iot_agent_rpm_amd64	N/A	N/A → 46.468 → 47.550
✅	iot_agent_suse_amd64	N/A	N/A → 46.467 → 47.550

[rdesgroppes]

This and #55044 seem very related. You and @chouetz should work this out together.

@aiuto Yep, that’s actually what we’re doing.