Skip to content

[ACTP] add ensure-enrollment command to PAR binary - #54870

Open
embeaken wants to merge 6 commits into
mainfrom
ilya/par-ensure-enrollment
Open

[ACTP] add ensure-enrollment command to PAR binary#54870
embeaken wants to merge 6 commits into
mainfrom
ilya/par-ensure-enrollment

Conversation

@embeaken

@embeaken embeaken commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds privateactionrunner ensure-enrollment, a CLI command that will be used when par-control starts. It:

  • reuses a valid persisted identity for the current host if one exists
  • self-enrolls and persists a new identity otherwise

It also shares enrollment-and-persistence logic with rotate-identity.

This was done to reuse enrollment Go code without reimplementing it in Rust.

Validation

  • bazel test //cmd/privateactionrunner/subcommands/ensureenrollment:ensureenrollment_test
  • bazel test //cmd/privateactionrunner/subcommands/rotateidentity:rotateidentity_test

@dd-octo-sts

dd-octo-sts Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Go Package Import Differences

Baseline: d473f2a
Comparison: c1e1143

binaryosarchchange
privateactionrunnerlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/ensureenrollment
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunnerlinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/ensureenrollment
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunnerwindowsamd64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/ensureenrollment
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunnerdarwinamd64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/ensureenrollment
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity
privateactionrunnerdarwinarm64
+2, -0
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/ensureenrollment
+github.com/DataDog/datadog-agent/cmd/privateactionrunner/subcommands/identity

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 56.19%
Overall Coverage: 52.46% (+0.04%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c1e1143 | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor d473f2ae:

Results for datadog-agent_7.84.0~devel.git.286.c1e1143.pipeline.131727366-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.286.c1e1143.pipeline.131727366-1_amd64.deb:

No change detected

@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from 6c22069 to cd87d21 Compare August 13, 2026 23:04
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 66e117b to e323571 Compare August 13, 2026 23:04
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/action-platform labels Aug 13, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Aug 13, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d473f2a
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -140.39 KiB (0.02% reduction, +3.22% of buffer) 760.339 → 760.202 → 764.600
agent_deb_amd64_fips -156.49 KiB (0.02% reduction, +5.86% of buffer) 713.231 → 713.078 → 715.840
agent_heroku_amd64 -48.0 KiB (0.02% reduction, +0.71% of buffer) 312.498 → 312.451 → 319.080
agent_msi -46.22 KiB (0.01% reduction, +0.27% of buffer) 644.036 → 643.991 → 661.050
agent_rpm_amd64 -140.39 KiB (0.02% reduction, +3.23% of buffer) 760.323 → 760.186 → 764.570
agent_rpm_amd64_fips -156.49 KiB (0.02% reduction, +5.82% of buffer) 713.215 → 713.062 → 715.840
agent_rpm_arm64 -128.27 KiB (0.02% reduction, +12.23% of buffer) 736.106 → 735.981 → 737.130
agent_rpm_arm64_fips -140.36 KiB (0.02% reduction, +9.21% of buffer) 692.332 → 692.195 → 693.820
agent_suse_amd64 -140.39 KiB (0.02% reduction, +3.23% of buffer) 760.323 → 760.186 → 764.570
agent_suse_amd64_fips -156.49 KiB (0.02% reduction, +5.82% of buffer) 713.215 → 713.062 → 715.840
agent_suse_arm64 -128.27 KiB (0.02% reduction, +12.23% of buffer) 736.106 → 735.981 → 737.130
agent_suse_arm64_fips -140.36 KiB (0.02% reduction, +9.21% of buffer) 692.332 → 692.195 → 693.820
docker_agent_amd64 -140.39 KiB (0.02% reduction, +11.80% of buffer) 818.978 → 818.841 → 820.140
docker_agent_arm64 -128.26 KiB (0.02% reduction, +11.98% of buffer) 819.844 → 819.719 → 820.890
docker_agent_jmx_amd64 -140.39 KiB (0.01% reduction, +13.39% of buffer) 1009.876 → 1009.739 → 1010.900
docker_agent_jmx_arm64 -128.27 KiB (0.01% reduction, +10.65% of buffer) 999.394 → 999.269 → 1000.570
17 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cluster_agent_amd64 211.151 MiB
docker_cluster_agent_arm64 224.268 MiB
docker_cws_instrumentation_amd64 7.443 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.463 MiB
docker_dogstatsd_arm64 37.560 MiB
docker_host_profiler_amd64 305.792 MiB
docker_host_profiler_arm64 317.103 MiB
dogstatsd_deb_amd64 30.204 MiB
dogstatsd_deb_arm64 28.236 MiB
dogstatsd_rpm_amd64 30.204 MiB
dogstatsd_suse_amd64 30.204 MiB
iot_agent_deb_amd64 46.467 MiB
iot_agent_deb_arm64 43.128 MiB
iot_agent_deb_armhf 43.926 MiB
iot_agent_rpm_amd64 46.468 MiB
iot_agent_suse_amd64 46.467 MiB

@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from cd87d21 to 6ba350e Compare August 13, 2026 23:10
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch 2 times, most recently from 1a16146 to 6b010be Compare August 13, 2026 23:48
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from 6ba350e to 481cfaf Compare August 13, 2026 23:48
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 14, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: ebdd6e86-0670-4063-ad8d-c3961b2b5976

Baseline: 83ec016
Comparison: c1e1143
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_private_action_runner memory utilization +0.70 [+0.57, +0.82] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.31 [+0.08, +0.55] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.21 [+0.16, +0.26] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.13 [+0.04, +0.21] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.09 [+0.06, +0.13] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.18 [-0.22, -0.14] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.31 [-0.34, -0.27] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -4.66 [-5.51, -3.80] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 172.98MiB ≤ 178MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 746.60KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 515.90MiB ≤ 538MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.15MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 16 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 211.39MiB ≤ 229MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.43MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 427.77 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 20 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 427.59MiB ≤ 439MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.80MiB ≤ 76MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 34.06 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 328.24MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 62.02 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 301.72MiB ≤ 314MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 24.67 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 313.35MiB ≤ 343MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 6b010be to 00a3402 Compare August 14, 2026 02:43
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from 481cfaf to 9960c56 Compare August 14, 2026 02:43
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 00a3402 to ea55c73 Compare August 14, 2026 13:18
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch 2 times, most recently from 9c657ce to 50ccce5 Compare August 14, 2026 14:17
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from ea55c73 to 690bb57 Compare August 14, 2026 14:19
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from 50ccce5 to f7b495c Compare August 14, 2026 16:37
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 690bb57 to c2aaa60 Compare August 14, 2026 16:40
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from f7b495c to 787ec32 Compare August 14, 2026 16:48
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch 2 times, most recently from 01b23ab to f821eba Compare August 14, 2026 17:53
@embeaken
embeaken marked this pull request as ready for review August 14, 2026 17:55
@embeaken
embeaken requested a review from a team as a code owner August 14, 2026 17:55
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from d34ebc0 to 606784f Compare August 15, 2026 00:18
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from e0cd96c to 6e4b0d0 Compare August 15, 2026 00:18
@aiuto
aiuto removed the request for review from a team August 17, 2026 02:41
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from 606784f to 85b0ed7 Compare August 17, 2026 16:01
@embeaken
embeaken requested review from a team as code owners August 17, 2026 16:01
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 6e4b0d0 to 29fbee2 Compare August 17, 2026 16:01
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch 2 times, most recently from c785c41 to fb58e03 Compare August 17, 2026 17:13
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 29fbee2 to 5d08287 Compare August 17, 2026 17:13
@embeaken
embeaken force-pushed the ilya/par-control-lifecycle branch from fb58e03 to 4fdaf12 Compare August 17, 2026 20:01
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 5d08287 to efcffd4 Compare August 17, 2026 20:03
Comment thread cmd/privateactionrunner/subcommands/ensureenrollment/command.go Outdated
Base automatically changed from ilya/par-control-lifecycle to main August 18, 2026 14:33
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 672b028 to d6f8b60 Compare August 18, 2026 14:43
@embeaken
embeaken requested a review from hush-hush August 18, 2026 14:43
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from d6f8b60 to 3c1138d Compare August 18, 2026 18:21
The recordingLogger fake implemented the whole log.Component surface for a
single test whose only exercised log line is a constant string, so it could
not detect a private-key leak. Key redaction is still covered by the invalid
configured private key case, which asserts the error does not echo the key.
A truncated or malformed identity file could keep ensure-enrollment failing
until it was deleted by hand, since persistIdentityToFile writes in place and a
crash mid-write leaves partial JSON behind.

Content-level damage is now marked with ErrIdentityCorrupt and treated as
unusable: ensure-enrollment warns, discards it, and continues to the configured
identity or self-enrollment, removing the file when a configured identity takes
over so par-control cannot pick it up again. I/O and K8s secret failures still
abort, because they may be transient and re-enrolling would register a second
runner for the same host.
getRunnerConfig hard-failed on any GetIdentityFromPreviousEnrollment error, so
the monolithic runner stayed wedged on a corrupt identity file while split mode
recovered from it. Treat ErrIdentityCorrupt as an absent identity there too, and
keep aborting on I/O failures.
@embeaken
embeaken force-pushed the ilya/par-ensure-enrollment branch from 3c1138d to c1e1143 Compare August 18, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/action-platform team/agent-build team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants