Skip to content

feat(vite): support Vite 8 (bump peerDependency range)#452

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
yoann/support-vite-8-via-minimal-peerdep-bump-dbab9bbd
Jul 14, 2026
Merged

feat(vite): support Vite 8 (bump peerDependency range)#452
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
yoann/support-vite-8-via-minimal-peerdep-bump-dbab9bbd

Conversation

@yoannmoinet

Copy link
Copy Markdown
Member

What and why?

Officially support Vite 8 in @datadog/vite-plugin with a minimal diff.

Rather than committing a heavy fixture + integration test to prove compatibility, Vite 8 was validated locally (see below). Validation showed the peer bump alone is sufficient — no source, rollup, or JSON-import changes were required.

How?

  • Changed peerDependencies.vite in packages/published/vite-plugin/package.json.
  • Ran yarn install; the resulting yarn.lock diff is limited to the same single workspace peer line.

Local Vite 8 validation (not committed):

  • Built the plugin (yarn workspace @datadog/vite-plugin build), then npm packed it (so the tarball honors publishConfig exports) and installed it into a throwaway /tmp Vite 8.1.4 (rolldown) smoke project running a real vite build.
  • Result: the plugin loads, the unplugin factory initializes, all custom hooks execute (bundler report, build report, true-end), and the build completes and emits reports. The only surfaced error was fetch failed when submitting analytics with a fake API key — expected and harmless.

Explicitly out of scope (kept out to preserve a minimal diff): the vite_react_router_project fixture, the vite8.test.ts integration test, the repo-wide rollup 4.62.0 bump / @types/estree resolution, and any dev/test Vite version changes.

Verification: typecheck clean, build clean, yarn cli integrity regenerated nothing, working tree clean (diff is 2 files, +2/−2).

Bump the vite peerDependency range from '>= 5.x <= 7.x' to '>= 5.x <= 8.x'.
Validated locally that @datadog/vite-plugin builds and runs cleanly under
Vite 8.1.4 (rolldown): the plugin loads, all hooks execute, and the build
completes and emits reports with only the peer bump — no source or rollup
changes required.

Supersedes #425 with a minimal diff.

Closes #423
@yoannmoinet
yoannmoinet marked this pull request as ready for review July 13, 2026 15:56
@yoannmoinet
yoannmoinet requested a review from a team as a code owner July 13, 2026 15:56
@yoannmoinet
yoannmoinet requested review from egeriis and removed request for a team July 13, 2026 15:56
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 30ef62c into master Jul 14, 2026
5 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the yoann/support-vite-8-via-minimal-peerdep-bump-dbab9bbd branch July 14, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vite 8 not supported

2 participants