Skip to content

chore: dogfood becwright with blocking self-rules#4

Merged
DataDave-Dev merged 3 commits into
mainfrom
chore/dogfood-self-rules
Jun 30, 2026
Merged

chore: dogfood becwright with blocking self-rules#4
DataDave-Dev merged 3 commits into
mainfrom
chore/dogfood-self-rules

Conversation

@DataDave-Dev

@DataDave-Dev DataDave-Dev commented Jun 30, 2026

Copy link
Copy Markdown
Owner

becwright now enforces itself with blocking rules in .bec/rules.yaml:

  • no-debug-remnants and no-dangerous-eval over src/becwright/*.py (top-level modules; checks/ is scoped out because those checks would match their own pattern definitions — the self-reference trap).
  • no-wildcard-imports across all of src and tests.
  • The existing comments-only-when-complex warning is kept.

CI already runs becwright check --all, so these gate every PR. The pre-commit hook can be installed locally with becwright install.

Summary by CodeRabbit

  • Chores
    • Added additional automated self-checks to strengthen code quality safeguards.
    • Enforced blocking checks to catch debugger remnants, wildcard imports, and eval()/exec() usage in key Python areas.

Adds blocking rules so becwright enforces itself: no debug remnants and no
eval/exec in the engine modules (src/becwright/*.py, scoping out checks/ to
avoid the self-reference trap), and no wildcard imports across src and tests.
CI already runs 'becwright check --all', so these gate every PR.
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8bfc86be-06b9-42a4-8522-6dec698d50c9

📥 Commits

Reviewing files that changed from the base of the PR and between 666e501 and f25d639.

📒 Files selected for processing (1)
  • .bec/rules.yaml

📝 Walkthrough

Walkthrough

Three blocking dogfooding rules are added to .bec/rules.yaml: no-debug-remnants (no PDB/debugger in src/becwright/*.py), no-wildcard-imports (no wildcard imports in src/becwright/**/*.py and tests/**/*.py), and no-dangerous-eval (no eval()/exec() in src/becwright/*.py). Each excludes the checks/ directory where applicable to avoid self-matching.

Changes

Blocking Lint Rules

Layer / File(s) Summary
Three new blocking self-check rules
.bec/rules.yaml
Adds no-debug-remnants, no-wildcard-imports, and no-dangerous-eval blocking rules, each scoped to relevant paths and referencing the corresponding becwright.checks.* module.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 No sneaky pdb left behind,
No import * to boggle the mind,
No eval lurking in the night—
The rules hop in to keep code right!
Config is tidy, bugs take flight! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers what and why, but it omits the required template sections and checklist items. Add the required ## What, ## Why, and ## Checklist sections, and include the test/docs status for each checklist item.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the main change: adding blocking self-rules to dogfood becwright.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/dogfood-self-rules

Comment @coderabbitai help to get the list of available commands.

@DataDave-Dev
DataDave-Dev merged commit f9cd43d into main Jun 30, 2026
2 of 3 checks passed
@DataDave-Dev
DataDave-Dev deleted the chore/dogfood-self-rules branch June 30, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant