chore: dogfood becwright with blocking self-rules#4
Conversation
Adds blocking rules so becwright enforces itself: no debug remnants and no eval/exec in the engine modules (src/becwright/*.py, scoping out checks/ to avoid the self-reference trap), and no wildcard imports across src and tests. CI already runs 'becwright check --all', so these gate every PR.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThree blocking dogfooding rules are added to ChangesBlocking Lint Rules
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
becwright now enforces itself with blocking rules in
.bec/rules.yaml:no-debug-remnantsandno-dangerous-evaloversrc/becwright/*.py(top-level modules;checks/is scoped out because those checks would match their own pattern definitions — the self-reference trap).no-wildcard-importsacross all ofsrcandtests.comments-only-when-complexwarning is kept.CI already runs
becwright check --all, so these gate every PR. The pre-commit hook can be installed locally withbecwright install.Summary by CodeRabbit
eval()/exec()usage in key Python areas.