Add tiled systolic-array matmul support for OS and WS#62
Merged
shirohasuki merged 11 commits intoJul 19, 2026
Conversation
shirohasuki
requested review from
SJM946 and
shirohasuki
and removed request for
SJM946
June 22, 2026 14:30
Member
|
Thanks for your time! I will do a quick review. |
shirohasuki
requested changes
Jun 23, 2026
shirohasuki
left a comment
Member
There was a problem hiding this comment.
Thank you so, so much for your work. I think we might need a README to explain the implementation of ball (no AIGC). To be honest, all these variables are a bit overwhelming.
| ) | ||
| endfunction() | ||
|
|
||
| function(add_singlecore_objdump_target TEST_NAME) |
Member
There was a problem hiding this comment.
What are these disassembly files used for? Are they necessary?
| "$inBank $outBank $iter $scale attr-dict `:` type($inBank) type($outBank) type($iter) type($scale)"; | ||
| } | ||
|
|
||
| #endif // BUCKYBALL_BANK_SSA |
Member
There was a problem hiding this comment.
Please run pre-commit before committing.
| // CHECK-DAG: %[[CFG_WS:.*]] = arith.constant 1 : i64 | ||
| // CHECK: buckyball.bank_systolic {{.*}} %[[C4]] %[[CFG_OS]] | ||
| // CHECK: buckyball.bank_mvout {{.*}} %[[C4]] | ||
| // CHECK: buckyball.bank_systolic {{.*}} %[[C4]] %[[CFG_WS]] |
Member
There was a problem hiding this comment.
Have you do filecheck, these seem are not right.
Member
|
Nice progress. |
nervestop2
force-pushed
the
systolic-array-os-ws-matmul
branch
from
July 17, 2026 08:43
1e99306 to
d6105de
Compare
shirohasuki
force-pushed
the
systolic-array-os-ws-matmul
branch
from
July 18, 2026 17:08
d6105de to
4da388e
Compare
…d Data Structures
…licIntrOp definitionres
shirohasuki
force-pushed
the
systolic-array-os-ws-matmul
branch
from
July 19, 2026 09:18
f78a87c to
1806d10
Compare
shirohasuki
force-pushed
the
systolic-array-os-ws-matmul
branch
from
July 19, 2026 11:16
16dc2a2 to
7846525
Compare
shirohasuki
force-pushed
the
systolic-array-os-ws-matmul
branch
from
July 19, 2026 12:42
da080ec to
000820b
Compare
shirohasuki
force-pushed
the
systolic-array-os-ws-matmul
branch
from
July 19, 2026 16:56
5fe99fc to
1d3fc20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改内容:
验证情况:
日志说明指令4x8_8x4能顺利编译成2次执行,bfp_ws_first 和bfp_ws_last。测试结果也PASS
[verilator sim] [instr 0] mvin_a_tile0 ptr=0x80003840 bank=0 depth=4 stride=1
[verilator sim] [instr 1] mvin_b_tile0 ptr=0x800038c0 bank=1 depth=4 stride=1
[verilator sim] [instr 2] bfp_ws_first op1_bank=0 op2_bank=1 wr_bank=2 iter=4 config[2:0]=0x3
[verilator sim] [instr 3] mvin_a_tile1 ptr=0x80003880 bank=0 depth=4 stride=1
[verilator sim] [instr 4] mvin_b_tile1 ptr=0x80003900 bank=1 depth=4 stride=1
[verilator sim] [instr 5] bfp_ws_last op1_bank=0 op2_bank=1 wr_bank=2 iter=4 config[2:0]=0x7
[verilator sim] [instr 6] mvout ptr=0x80003740 bank=2 depth=4 stride=1
[verilator sim] [instr 7] fence
[verilator sim] output_matrix =
[verilator sim] 27252 22036 11089 27480
[verilator sim] 34675 27701 29213 38586
[verilator sim] 28397 27587 24762 39769
[verilator sim] 27343 21374 14741 34213
[verilator sim] expected_matrix =
[verilator sim] 27252 22036 11089 27480
[verilator sim] 34675 27701 29213 38586
[verilator sim] 28397 27587 24762 39769
[verilator sim] 27343 21374 14741 34213
[verilator sim] systolic_matmul_4x8_8x4_ws PASSED