Skip to content

fix(typings): robloxID in API response#1

Merged
DaStormer merged 1 commit into
DaStormer:mainfrom
dgxo:patch-1
Jul 9, 2025
Merged

fix(typings): robloxID in API response#1
DaStormer merged 1 commit into
DaStormer:mainfrom
dgxo:patch-1

Conversation

@dgxo

@dgxo dgxo commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Currently, the types DiscordToRobloxGuildAPIResponse and DiscordToRobloxGlobalAPIResponse in src/typings.ts do not match the actual Bloxlink API, as described on the Developer dashboard, having robloxId instead of the correct robloxID. This PR fixes that.

  • Changes have been sufficiently tested or do not alter functionality.

@dgxo dgxo requested a review from DaStormer as a code owner July 1, 2025 14:26
@dgxo

dgxo commented Jul 4, 2025

Copy link
Copy Markdown
Contributor Author

You have to merge it too, approving just means it can be merged

@DaStormer

Copy link
Copy Markdown
Owner

I'm aware, just busy.

@DaStormer DaStormer changed the title Fix incorrect typings fix(typings): robloxID in API response Jul 9, 2025
@DaStormer DaStormer merged commit c315c27 into DaStormer:main Jul 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants