refactor: Remove unused log modules, enhanced log! macro#9
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors logging infrastructure by removing unused log modules and enhancing the log! macro functionality. The changes streamline error logging by replacing direct tracing::error! calls with a unified log! macro.
Key changes:
- Removed unused log modules (task, event, io, misc) that only contained placeholder entries
- Enhanced the log! macro to accept error references instead of requiring ownership
- Updated error handling throughout the codebase to use the new log! macro
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ui/schedule_page.rs | Replaced tracing::error! calls with log! macro usage |
| src/ui/execution_page.rs | Replaced tracing::error! calls with log! macro usage |
| src/model/log/task.rs | Removed unused placeholder log module |
| src/model/log/mod.rs | Updated module exports to remove deleted log modules |
| src/model/log/misc.rs | Removed unused placeholder log module |
| src/model/log/io.rs | Removed unused placeholder log module |
| src/model/log/event.rs | Removed unused placeholder log module |
| src/model/error/mod.rs | Added level() method to Error enum for log macro compatibility |
| src/core/schedule/schedule_timer.rs | Replaced tracing::error! calls with log! macro usage |
| src/core/backup/backup_engine.rs | Replaced tracing::error! calls with log! macro usage |
| macros/src/log.rs | Enhanced log! macro to accept error references |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.