Skip to content

refactor: Remove unused log modules, enhanced log! macro#9

Merged
DaLaw2 merged 1 commit into
masterfrom
dalaw2-dev
Sep 11, 2025
Merged

refactor: Remove unused log modules, enhanced log! macro#9
DaLaw2 merged 1 commit into
masterfrom
dalaw2-dev

Conversation

@DaLaw2

@DaLaw2 DaLaw2 commented Sep 11, 2025

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings September 11, 2025 15:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors logging infrastructure by removing unused log modules and enhancing the log! macro functionality. The changes streamline error logging by replacing direct tracing::error! calls with a unified log! macro.

Key changes:

  • Removed unused log modules (task, event, io, misc) that only contained placeholder entries
  • Enhanced the log! macro to accept error references instead of requiring ownership
  • Updated error handling throughout the codebase to use the new log! macro

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/ui/schedule_page.rs Replaced tracing::error! calls with log! macro usage
src/ui/execution_page.rs Replaced tracing::error! calls with log! macro usage
src/model/log/task.rs Removed unused placeholder log module
src/model/log/mod.rs Updated module exports to remove deleted log modules
src/model/log/misc.rs Removed unused placeholder log module
src/model/log/io.rs Removed unused placeholder log module
src/model/log/event.rs Removed unused placeholder log module
src/model/error/mod.rs Added level() method to Error enum for log macro compatibility
src/core/schedule/schedule_timer.rs Replaced tracing::error! calls with log! macro usage
src/core/backup/backup_engine.rs Replaced tracing::error! calls with log! macro usage
macros/src/log.rs Enhanced log! macro to accept error references

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/core/backup/backup_engine.rs
@DaLaw2
DaLaw2 merged commit 98cb0f9 into master Sep 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants