fix: Fix UI bottom not working#7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements UI functionality for managing backup schedules and improves system shutdown handling. The main purpose is to fix the "UI bottom not working" issue by adding edit and run functionality to the schedule management interface.
- Added complete schedule editing functionality with a dedicated dialog
- Implemented "Run Now" feature for executing schedules immediately
- Enhanced system shutdown process with proper resource cleanup
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/schedule_page.rs | Major addition of schedule editing UI with dialog, form handling, and run-now functionality |
| src/ui/execution_page.rs | Fixed execution display update logic to always create new display objects |
| src/model/core/schedule/schedule.rs | Changed execution UUID generation to create unique IDs instead of reusing schedule UUID |
| src/core/system.rs | Added proper shutdown sequence and stored manager references for cleanup |
| src/core/infrastructure/database_manager.rs | Added shutdown method with database pool closure and lock release |
| src/core/infrastructure/communication_manager.rs | Added handler cleanup method for proper shutdown |
| src/core/infrastructure/io_manager.rs | Converted Drop trait to explicit shutdown method |
| src/utils/database_lock.rs | Added manual lock release method |
| src/core/backup/backup_engine.rs | Added missing event type registrations for UI communication |
| config.toml | Added channel capacity configuration |
| Cargo.toml | Updated dependency versions to newer releases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.