Skip to content

fix: Fix UI bottom not working#7

Merged
DaLaw2 merged 1 commit into
masterfrom
dalaw2-dev
Aug 25, 2025
Merged

fix: Fix UI bottom not working#7
DaLaw2 merged 1 commit into
masterfrom
dalaw2-dev

Conversation

@DaLaw2

@DaLaw2 DaLaw2 commented Aug 25, 2025

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings August 25, 2025 08:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements UI functionality for managing backup schedules and improves system shutdown handling. The main purpose is to fix the "UI bottom not working" issue by adding edit and run functionality to the schedule management interface.

  • Added complete schedule editing functionality with a dedicated dialog
  • Implemented "Run Now" feature for executing schedules immediately
  • Enhanced system shutdown process with proper resource cleanup

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ui/schedule_page.rs Major addition of schedule editing UI with dialog, form handling, and run-now functionality
src/ui/execution_page.rs Fixed execution display update logic to always create new display objects
src/model/core/schedule/schedule.rs Changed execution UUID generation to create unique IDs instead of reusing schedule UUID
src/core/system.rs Added proper shutdown sequence and stored manager references for cleanup
src/core/infrastructure/database_manager.rs Added shutdown method with database pool closure and lock release
src/core/infrastructure/communication_manager.rs Added handler cleanup method for proper shutdown
src/core/infrastructure/io_manager.rs Converted Drop trait to explicit shutdown method
src/utils/database_lock.rs Added manual lock release method
src/core/backup/backup_engine.rs Added missing event type registrations for UI communication
config.toml Added channel capacity configuration
Cargo.toml Updated dependency versions to newer releases

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/ui/schedule_page.rs
Comment thread src/ui/schedule_page.rs
@DaLaw2
DaLaw2 merged commit ab0897f into master Aug 25, 2025
1 check passed
@DaLaw2
DaLaw2 deleted the dalaw2-dev branch August 25, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants