feat: Rewrote the system architecture#5
Merged
Merged
Conversation
…remove redundant implementations
…ased architecture
… refine actor-driven architecture
There was a problem hiding this comment.
Pull Request Overview
This pull request implements a major architectural refactoring that replaces the Event System with an Actor System to address circular dependencies between components. The changes reorganize the project structure, remove file locking functionality, and introduce modern actor-based communication patterns.
- Event-driven architecture replaced with Actor System for better dependency management
- Removed file lock utilities and simplified backup options
- Reorganized module structure moving core models to separate hierarchical organization
Reviewed Changes
Copilot reviewed 70 out of 72 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/mod.rs | Removes file_lock module export |
| src/utils/file_lock.rs | Completely removes file locking implementation |
| src/model/core/ | New hierarchical model organization with actor, backup, gui, and schedule modules |
| src/core/infrastructure/ | Infrastructure components moved to dedicated module |
| src/core/backup/ | Backup engine refactored to use actor system instead of events |
| src/ui/ | UI components updated to use actor system and new model structure |
| src/platform/ | File system interfaces updated to use Path instead of PathBuf |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote the system architecture.
Removed the Event System and added the Actor System to address circular dependencies between components.
Adjusted project organization.
Removed some functionality.