Skip to content

TMS TF final design#79

Merged
ast0815 merged 5 commits into
masterfrom
TMS_horizontalbar_periodicity
Jan 28, 2026
Merged

TMS TF final design#79
ast0815 merged 5 commits into
masterfrom
TMS_horizontalbar_periodicity

Conversation

@kyjung123

Copy link
Copy Markdown
Member

This PR updates the TMS cassette configuration to match the final approved design, here:

50 cassettes measure X (vertical bars), 32 cassettes measure Y (horizontal bars).
X, Y pair in front of TMS, then one cassette after each plate
Exact pattern is 8 “X+Y” then 22 “X+X+Y” cassettes

This update basically just modifies the order array in the TMS.cfg and changes its name.

Note: The steel stacking plan was already updated in a previous PR

@kyjung123 kyjung123 self-assigned this Jan 27, 2026
@github-actions

Copy link
Copy Markdown

Geometry is ready for visual inspection at https://dune.github.io/dunendggd/

Comment thread duneggd/Config/TMS.cfg
Comment thread duneggd/Config/TMS.cfg Outdated
Comment thread duneggd/SubDetector/TMS.py Outdated
@AsaNehm

AsaNehm commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

The code looks good to me, apart from the small comments

@ast0815

ast0815 commented Jan 28, 2026

Copy link
Copy Markdown
Member

The online 3D geometry viewer does not work. There is a bug I will fix before merging this, so we can have a look at the geometry.

Side note: You should not make the same commit message over and over. Actually write in each commit what it changes.

@ast0815
ast0815 merged commit 46f12a4 into master Jan 28, 2026
4 checks passed
@ast0815
ast0815 deleted the TMS_horizontalbar_periodicity branch January 28, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants