TMS TF final design#79
Merged
Merged
Conversation
|
Geometry is ready for visual inspection at https://dune.github.io/dunendggd/ |
AsaNehm
reviewed
Jan 28, 2026
AsaNehm
reviewed
Jan 28, 2026
AsaNehm
reviewed
Jan 28, 2026
Contributor
|
The code looks good to me, apart from the small comments |
AsaNehm
approved these changes
Jan 28, 2026
Member
|
The online 3D geometry viewer does not work. There is a bug I will fix before merging this, so we can have a look at the geometry. Side note: You should not make the same commit message over and over. Actually write in each commit what it changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the TMS cassette configuration to match the final approved design, here:
This update basically just modifies the order array in the TMS.cfg and changes its name.
Note: The steel stacking plan was already updated in a previous PR