Skip to content

Better health probes#34

Merged
jcpunk merged 2 commits into
DUNE-DAQ:developfrom
jcpunk:better-probes
Jun 10, 2026
Merged

Better health probes#34
jcpunk merged 2 commits into
DUNE-DAQ:developfrom
jcpunk:better-probes

Conversation

@jcpunk

@jcpunk jcpunk commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

The kubernetes pod currently has "did the socket open" checks. This simply verifies that gunicorn isn't crashed. These improved checks at least verify flask is running.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Verified with pytest -v

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jcpunk jcpunk requested a review from gcrone June 9, 2026 17:28

@eflumerf eflumerf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@jcpunk jcpunk merged commit 6d75903 into DUNE-DAQ:develop Jun 10, 2026
1 check failed
@jcpunk jcpunk deleted the better-probes branch June 10, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants