Replace replaceable functions with inspectable models - #362
Open
tobiasreischl wants to merge 1 commit into
Open
Conversation
Replace the replaceable pressure-loss and turbo characteristic functions with replaceable model classes. Instantiate the selected models in FlowResistance and PartialTurboComponent so internal variables such as Reynolds number, friction factor, pressure ratio and specific work are available in simulation results. Update all dependent redeclarations in tests and examples and add separate pressure-loss model instances for both flow directions in the undirected FlowResistance. Closes DLR-SR#47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the replaceable pressure-loss and turbo characteristic functions with replaceable model classes.
Instantiate the selected models in FlowResistance and PartialTurboComponent so internal variables such as Reynolds number, friction factor, pressure ratio and specific work are available in simulation results.
Update all dependent redeclarations in tests and examples and add separate pressure-loss model instances for both flow directions in the undirected FlowResistance.
Closes #47