Skip to content

Remove obsolete heat port from turbo components #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobiasreischl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove obsolete heat port from turbo components #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions ThermofluidStream/Processes/Internal/PartialTurboComponent.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ partial model PartialTurboComponent "Partial model of turbo component"

parameter Boolean omega_from_input = false "= true, if omega input connector is enabled"
annotation(Evaluate=true, HideResult=true, choices(checkBox=true));
parameter Boolean enableAccessHeatPort = false "= true, if heatPort is enabled"
annotation(Evaluate=true, HideResult=true, choices(checkBox=true));
parameter SI.MomentOfInertia J_p = 5e-4 "Moment of inertia"
annotation(Dialog(group="Parameters", enable=not omega_from_input));
parameter Boolean enableOutput = false "= true, if selectable quantity output connector is enabled"
Expand Down Expand Up @@ -38,8 +36,6 @@ partial model PartialTurboComponent "Partial model of turbo component"
annotation (Placement(transformation(extent={{-10,-110},{10,-90}})));
Modelica.Blocks.Interfaces.RealInput omega_input(unit = "rad/s") = omega if omega_from_input "Angular velocity input connector [rad/s]"
annotation (Placement(transformation(extent={{-20,-20},{20,20}}, origin={0,-120}, rotation=90)));
Modelica.Thermal.HeatTransfer.Interfaces.HeatPort_a heatport(Q_flow = Q_t) if enableAccessHeatPort "HeatPort"
annotation (Placement(transformation(extent={{-70,-110},{-50,-90}})));
Modelica.Blocks.Interfaces.RealOutput output_val(unit=Sensors.Internal.getFlowUnit(outputQuantity)) = getQuantity(inlet.state, m_flow, outputQuantity, rho_min) if enableOutput "Quantity output connector"
annotation (Placement(transformation(extent={{-10,-10},{10,10}},rotation=270,origin={60,-110})));

Expand All @@ -58,7 +54,6 @@ function getQuantity = Sensors.Internal.getFlowQuantity (
</html>"));

SI.Power W_t "Power (technichal work flow rate)";
SI.Power Q_t "Heat flow rate";
SI.Torque tau_st "Steady-state torque";

protected
Expand Down Expand Up @@ -97,12 +92,9 @@ equation
W_t = tau_st*omega;
dh = (m_flow*W_t)/(m_flow^2 + (m_flow_reg)^2);
if noEvent(W_t >= 0) then
// if work is given to fluid, dump access heat to port
Q_t = W_t - m_flow*dh;
tau_normalized = tau_st;
else
// if work is taken from fluid, reduce tau, so that the work can be taken from the fluid
Q_t = 0;
tau_normalized = dh*m_flow/(noEvent(if abs(omega)>omega_reg then omega else (if omega < 0 then -omega_reg else omega_reg)));
end if;

Expand Down Expand Up @@ -137,19 +129,18 @@ equation
lineThickness=0.5,
fillColor={255,255,255},
fillPattern=FillPattern.Solid),
Line(visible=enableAccessHeatPort, points={{-60,-100},{-60,-68},{-38,-46}}, color={191,0,0}),
Line(
visible=enableOutput,
points={{60,-100},{60,-68},{38,-46}},
color={0,0,127}),
Line(visible=omega_from_input,
points={{0,-100},{0,-60}},
color={0,0,127}),
Rectangle(visible=not omega_from_input,
lineColor={64,64,64},
fillColor={191,191,191},
fillPattern=FillPattern.HorizontalCylinder,
extent={{-100.0,-10.0},{-50.0,10.0}},
Rectangle(visible=not omega_from_input,
lineColor={64,64,64},
fillColor={191,191,191},
fillPattern=FillPattern.HorizontalCylinder,
extent={{-100.0,-10.0},{-50.0,10.0}},
rotation=90),
Ellipse(
extent={{-60,60},{60,-60}},
Expand All @@ -159,7 +150,7 @@ equation
fillPattern=FillPattern.Solid)}),
Diagram(coordinateSystem(preserveAspectRatio=true)),
Documentation(info="<html>
<p>This model has an inlet and an outlet, representing a single fluid stream, as well as a flange to exchange mechanical work, an optional heatport to dump heat that the fluid cannot take on, and an optional output for a measureable quantity.</p>
<p>This model has an inlet and an outlet, representing a single fluid stream, as well as a flange to exchange mechanical work. And also an optional output for a measureable quantity.</p>
<p>The component does the following:</p>
<ol>
<li>Compute the pressure differential and the moment on the flange, that would result in static operation from characteristic curves (static moment). These curves differ for different components.</li>
Expand All @@ -171,7 +162,6 @@ equation
<ul>
<li>The optional output might be useful for simplifying the overall model in a control loop, since no additional sensor is required. </li>
<li>If one wants to prescribe a speed of the component, instead of being interested in the omega dynamics, enable omegaFromInput.</li>
<li>The heatport is only of interest, if the overall energy of the system must be conserved.</li>
</ul>
</html>"));
end PartialTurboComponent;
19 changes: 8 additions & 11 deletions ThermofluidStream/Processes/Tests/Pump.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,15 @@ Medium model for the test. Should be incompressible or with low compressibility.
tf.Topology.JunctionN junctionN(N=4, redeclare package Medium = Medium,
L=0)
annotation (Placement(transformation(extent={{60,20},{80,40}})));
tf.Processes.Pump pump_directParamWithHeatPort(
tf.Processes.Pump pump_directParam(
redeclare package Medium = Medium,
L=10000,
omega_from_input=true,
initM_flow=ThermofluidStream.Utilities.Types.InitializationMethods.state,
enableAccessHeatPort=true,
redeclare function dp_tau_pump = tf.Processes.Internal.TurboComponent.dp_tau_nominal_flow (parametrizeByDesignPoint
=false, k_p_input=1e7)) annotation (Placement(transformation(extent={{-10,-50},{10,-30}})));
redeclare function dp_tau_pump =
tf.Processes.Internal.TurboComponent.dp_tau_nominal_flow (
parametrizeByDesignPoint=false, k_p_input=1e7))
annotation (Placement(transformation(extent={{-10,-50},{10,-30}})));
Modelica.Blocks.Sources.Constant pump2_speed_rad_s(k=3200)
annotation (Placement(transformation(extent={{40,-70},{20,-50}})));
tf.Processes.Pump pump_directParamPowerIn(
Expand All @@ -84,8 +85,6 @@ Medium model for the test. Should be incompressible or with low compressibility.
tf.Processes.Tests.Power powerSource2(P=5000, tau_max=150)
annotation (Placement(transformation(extent={{-40,-120},{-20,-100}})));

Modelica.Thermal.HeatTransfer.Sources.FixedTemperature fixedTemperature(T=
283.15) annotation (Placement(transformation(extent={{-40,-70},{-20,-50}})));
tf.Processes.Pump pump_designPointOmega100(
redeclare package Medium = Medium,
L=10000,
Expand Down Expand Up @@ -133,15 +132,15 @@ equation
points={{-10,30},{-52,30},{-52,30.75}},
color={28,108,200},
thickness=0.5));
connect(pump_directParamWithHeatPort.omega_input, pump2_speed_rad_s.y)
connect(pump_directParam.omega_input, pump2_speed_rad_s.y)
annotation (Line(points={{0,-52},{0,-60},{19,-60}}, color={0,0,127}));
connect(powerSource2.flange, pump_directParamPowerIn.flange)
annotation (Line(points={{-22.4,-110},{0,-110},{0,-100}}, color={0,0,0}));
connect(pump_defaultDesignPoint_PowerIn.inlet, splitterN.outlets[3]) annotation (Line(
points={{-10,0},{-44,0},{-44,30.25},{-52,30.25}},
color={28,108,200},
thickness=0.5));
connect(pump_directParamWithHeatPort.inlet, splitterN.outlets[2]) annotation (Line(
connect(pump_directParam.inlet, splitterN.outlets[2]) annotation (Line(
points={{-10,-40},{-46,-40},{-46,29.75},{-52,29.75}},
color={28,108,200},
thickness=0.5));
Expand All @@ -153,7 +152,7 @@ equation
points={{10,-90},{52,-90},{52,29.25},{60,29.25}},
color={28,108,200},
thickness=0.5));
connect(pump_directParamWithHeatPort.outlet, junctionN.inlets[2]) annotation (Line(
connect(pump_directParam.outlet, junctionN.inlets[2]) annotation (Line(
points={{10,-40},{48,-40},{48,29.75},{60,29.75}},
color={28,108,200},
thickness=0.5));
Expand All @@ -167,8 +166,6 @@ equation
points={{10,30},{60,30},{60,30.75}},
color={28,108,200},
thickness=0.5));
connect(fixedTemperature.port, pump_directParamWithHeatPort.heatport)
annotation (Line(points={{-20,-60},{-6,-60},{-6,-50}}, color={191,0,0}));
connect(pump4_speed_rad_s.y, pump_designPointOmega100.omega_input)
annotation (Line(points={{-19,100},{0,100},{0,92}}, color={0,0,127}));
connect(source1.outlet, pump_designPointOmega100.inlet)
Expand Down
Loading