Skip to content

refactor(observe): migrate peek-fd to DKapture framework#100

Closed
yuKing123-king wants to merge 1 commit into
DKapture:mainfrom
yuKing123-king:refactor/peek-fd
Closed

refactor(observe): migrate peek-fd to DKapture framework#100
yuKing123-king wants to merge 1 commit into
DKapture:mainfrom
yuKing123-king:refactor/peek-fd

Conversation

@yuKing123-king

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread so/data-map.cpp
SAFE_DELETE(m_shm);
}

void DataMap::shutdown()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有调用,废代码,仔细检查下其他地方

Comment thread so/data-map.cpp

DataMap::~DataMap(void)
{
m_closing = true;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加这个什么作用?

Comment thread observe/Makefile
SO_NAMES = bpf-linker pin-registry btf-preprocessor
SO_OBJS = $(addprefix $(BUILD_DIR)/,$(addsuffix .o,$(SO_NAMES)))

$(addprefix $(BUILD_DIR)/,$(DKAPTURE_TARGETS)): LDFLAGS += -L$(PROJ_ROOT)/build/so -ldkapture -Wl,-rpath,$(PROJ_ROOT)/build/so

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Wl,-rpath,$(PROJ_ROOT)/build/so ??????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants