fix: Correct logic in time selection#793
Open
sfayer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
There is a subtle bug in all of the panels that use time selection; when Time Span "For all time?" is selected, the endTime is mistakenly set to the current time in hours:minutes and included in the request parameters rather than being left blank. This causes things which have changed in the current minute to not be displayed. The root cause of this is a tiny logic bug which means that the wrong path is taken when "For all time" (iSpanValue = 0) is selected.
This visible effect of this was that if you were watching the Job Monitor, for example, jobs which had just started running would "disappear" for up to 60 seconds, until the minute rolled over and then they would reappear.
Regards,
Simon
BEGINRELEASENOTES
FIX: Correct logic in time selection panel
ENDRELEASENOTES