Persist generated outline state immediately after /generate_outline

[Copilot]

/generate_outline wrote all generated state (title, chapter list, characters, planning artifacts, voice seed) into the Flask session but never persisted it to disk — so a crash or restart before /approve_outline silently discarded all that expensive LLM work.

Changes

• novelforge/routes/outline.py — Call save_session_state() after all session fields are populated in generate_outline(), matching the existing pattern in approve_outline():

session["pov_focal_character_plan"] = pov_focal_character_plan

# Auto-save session state after outline generation for crash recovery
save_session_state()  # ← added

return jsonify({...})

• tests/test_session.py — New TestGenerateOutlinePersistence class with three tests:
  • Session file exists on disk with correct fields after a successful /generate_outline
  • All planning artifacts and voice seed are present in the persisted file, and restore_session_from_state() can fully recover the session without ever hitting /approve_outline
  • Voice seed is included in the persisted state

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• api.openai.com
  • Triggering command: /usr/bin/python python -m pytest -q (dns block)
  • Triggering command: /usr/bin/python python -m pytest --tb=short (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

This PR ensures the expensive state generated by /generate_outline (title, outline, characters, planning artifacts, and voice seed) is persisted to disk immediately, improving crash/restart recovery without requiring a subsequent /approve_outline.

Changes:

• Persist session state to disk at the end of generate_outline() via save_session_state().
• Add tests asserting that /generate_outline creates a session JSON file containing the expected fields and that the saved state can be restored.
• Add a targeted test to ensure the voice_seed is included in the persisted state.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
novelforge/routes/outline.py	Saves generated outline/planning state to disk immediately after populating the Flask session.
tests/test_session.py	Adds tests validating persistence and restorability of /generate_outline session state (including voice_seed).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Unused import: get_session_id is imported but never referenced in this test. Removing it will keep the test focused and avoid accumulating dead imports as the suite grows.

Suggested change

from novelforge.session.persistence import get_session_id

[Copilot]

This test reads the persisted JSON file without first asserting it exists. Adding an explicit assert session_file.exists() (as done in the other tests in this class) will yield a clearer assertion failure if persistence breaks.

Suggested change

	session_file = Path(config.NOVELS_DIR) / f"{session_id}.json"
	session_file = Path(config.NOVELS_DIR) / f"{session_id}.json"
	assert session_file.exists(), "Session file must be created after /generate_outline"