feat: complete the hybrid retrieval backlog - #182
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (26)
Cache: Disabled due to Reviews > Disable Cache setting 📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR reworks omind's hybrid search index (int8 quantized vectors, throttled refresh, adaptive query scope, reranking, and generated/superseded-note weighting), adds note supersession metadata, access-based dynamic core promotion, an ChangesRetrieval Quality & Search Index Overhaul
Estimated code review effort: 4 (Complex) | ~75 minutes Note Supersession, Access Tracking & Consolidation
Estimated code review effort: 4 (Complex) | ~60 minutes Unified graph MCP tool
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant SearchIndex
participant SQLiteIndex
Client->>SearchIndex: search(query, limit)
SearchIndex->>SearchIndex: _refresh_if_needed()
SearchIndex->>SearchIndex: _scope(query, limit)
SearchIndex->>SQLiteIndex: keyword and vector legs (depth)
SearchIndex->>SearchIndex: rerank fused head
SearchIndex->>SearchIndex: weight generated/superseded notes
SearchIndex-->>Client: materialized results (excerpt_chars)
sequenceDiagram
participant CLI
participant Consolidate
participant OmiStore
CLI->>Consolidate: propose(limit)
Consolidate->>Consolidate: find candidate pairs, build draft
Consolidate-->>CLI: plan.json + draft.md
CLI->>Consolidate: apply(plan_id)
Consolidate->>Consolidate: validate plan, check source versions
Consolidate->>OmiStore: create_and_disable_sources(draft, sources)
OmiStore-->>Consolidate: ApplyResult
Consolidate-->>CLI: merged filename + archived sources
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Fixed operational/persona notes above remain pinned; generated and | ||
| # credential-looking notes are never promoted into always-on context. | ||
| try: | ||
| from omind import access, retrieve |
| # credential-looking notes are never promoted into always-on context. | ||
| try: | ||
| from omind import access, retrieve | ||
| from omind.store import OmiStore, parse_note |
| f"===== OMI capsule: {name} (dynamic core) =====\n{digest}" | ||
| ) | ||
| added += 1 | ||
| except Exception: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omind consolidateproposals with stale-source protectiongraph(op=...)with a one-release compatibility bridge; alias removal remains tracked in Remove deprecated graph-* MCP aliases after the compatibility release #181Validation
ruff check .mypy src(strict)pip-auditpytest -q— 839 passedCloses #167
Closes #168
Closes #169
Closes #170
Closes #171
Closes #172
Closes #173
Closes #174
Closes #175
Closes #176
Closes #177
Closes #178
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/