Run db-migrate Cloud Run job before updating services#400
Merged
Conversation
deploy-cloudrun now looks for a Cloud Run job named db-migrate (created by the gcp/cloudrun/app terraform module when database_migrations is enabled). When present, the job image is updated and the job executed to completion before any service is updated — a failed migration fails the deploy and leaves the running services untouched. Projects without the job are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
deploy-cloudrun now lists all Cloud Run jobs and updates each job's image and secrets, not just db-migrate. This keeps scheduled_jobs (gcp/cloudrun/app) on the freshly built image instead of the stale image resolved at terraform apply time. db-migrate is still the only job executed during deploy (to completion, before services and other jobs are touched); every other job is updated in place and runs on its own Cloud Scheduler cron. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
davidhollenberger
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-cloudrunnow looks for a Cloud Run job nameddb-migrate, created by thegcp/cloudrun/appterraform module whendatabase_migrationsis enabled (CruGlobal/cru-terraform-modules#635).gcloud run jobs update) sinceUpdateJobRequesthas noupdateMask; the env merge logic is now shared between jobs and services.dist/rebuilt.🤖 Generated with Claude Code