Make Skooner 'view' role actually grant view#263
Merged
Conversation
added 2 commits
June 11, 2026 15:42
The ce-registry workflow standard treats view as "revoke every elevated binding", which left the SA with no permissions and made the UI useless after a view run. Reworking the model so the cluster-wide view binding is the always-on baseline: - skooner.yaml: baked CRB renamed skooner-sa → skooner-sa-view and bound to ClusterRole view (was cluster-admin) - skooner-token.yml: removes the old skooner-sa-developer-view CRB step (the baseline covers it). 'developer' adds only the namespaced edit RoleBinding. 'cluster-admin' creates a new skooner-sa-admin CRB so it doesn't clash with the baseline. 'view' just strips elevated bindings; the baseline stays in place. Backwards-compat cleanup deletes any bindings from the old naming scheme. - INFRASTRUCTURE-SUMMARY.md: rewrites the role descriptions Applied to all three clusters; the stale cluster-admin CRB was deleted from sandbox + prod (test already had it removed by an earlier view run).
The NLB-fronted ingress was SNAT'ing all traffic to the node IP, so nginx whitelist-source-range annotations matched node IPs (10.x.x.x) and rejected every external client. Setting externalTrafficPolicy: Local on the ingress-nginx Service makes kube-proxy stop SNAT'ing and lets the AWS NLB deliver traffic with the real source IP. With 2 ingress-nginx replicas pinned to system nodes and NLB cross-zone routing, this is safe for our setup. Applied via helm upgrade in sandbox (verified: NGINX now logs the real client IP and the skooner-ingress whitelist annotation works). Test and production values files updated; helm upgrades on those clusters will be applied separately so the brief NLB health-check retarget can be timed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the surprising RBAC semantics from #260 where
role=viewrevoked everything (leaving the SA with no permissions). Reworks the binding model so cluster-wide view is the always-on baseline and the workflow only manages elevated bindings on top.Manifest change
skooner.yaml(all three envs):skooner-sa→skooner-sa-viewClusterRole/view(wascluster-admin)Workflow change
rolesemantics now match their names:roleviewskooner-sa-viewremains → cluster-wide read accessdeveloperskooner-sa-developer-editRoleBinding (editonctdl-xtrans). Baseline view still applies cluster-widecluster-adminskooner-sa-adminClusterRoleBinding. Baseline view becomes redundant but harmlessEach path also tears down the bindings the other paths would have added, and includes backwards-compat cleanup for the prior naming scheme.
Cluster state already reconciled
All three clusters were updated directly:
skooner-sa-viewCRB applied in eachskooner-sa(cluster-admin) CRB deleted from sandbox + prod (test already had it removed by the earlier view workflow run)Docs
INFRASTRUCTURE-SUMMARY.mdSkooner section rewritten.Test plan
skooner-sa-viewbinding as baselinerole=viewkeeps view, deletes elevated → SA can list pods/nodes/services etc.role=developeradds namespaced editrole=cluster-adminadds full admin