Refactor course to course data#1721
Open
AngelsandDevsLOL wants to merge 3 commits into
Open
Conversation
Coverage Report for CI Build 23Coverage remained the same at 58.609%Details
Uncovered Changes
Coverage Regressions14 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR moves the existing
Coursedata type inDatabase/Tables.hstoModels/Course.hs, and renames it toCourseData. This data type is used to return course data from the back-end to the front-end. It is separate fromCoursesinDatabase/Tables.hs, which is used for internal back-end use.Methods in
Models/Course.hsis updated to useCourseDatainstead ofCourse. The import,import Database.Tables hiding (breadth, distribution)is changed to justimport Database.Tablessince the breadth and distribution for the Course data type is no longer there. The parameters forinsertCourseis also adjusted accordingly.Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)