Skip to content

dependabot configuration#356

Closed
faddat wants to merge 1 commit into
CosmWasm:mainfrom
notional-labs:dependabot
Closed

dependabot configuration#356
faddat wants to merge 1 commit into
CosmWasm:mainfrom
notional-labs:dependabot

Conversation

@faddat

@faddat faddat commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

This PR configures dependabot for github actions, go, and cargo.

Likely a PR or two using github actions upcoming, might as well automatically maintain that too.

@faddat faddat mentioned this pull request Oct 26, 2022
@faddat

faddat commented Dec 22, 2024

Copy link
Copy Markdown
Contributor Author

@webmaster128 bump sir. It is a good idea to keep things up to date.

@faddat

faddat commented Feb 18, 2025

Copy link
Copy Markdown
Contributor Author

Really, it's good to keep things up to date.

@chipshort

Copy link
Copy Markdown
Contributor

Libraries should specify the minimum semver-compatible dependency version, not the latest one, so the applications using the library can decide for themselves.
We also should not just update rust dependencies in here willy-nilly. Ideally, we should keep the versions synchronized between this repo and the cosmwasm repo. Otherwise, our huge test suite in cosmwasm runs against different dependency versions than what we actually deploy. Updates aren't always good. They can break stuff.

In general, I'm also not a big fan of dependabot. It creates dozens of small PRs that just become a nuisance. I can see us merging the github-actions part, since that shouldn't be too many PR.

@faddat

faddat commented Feb 18, 2025

Copy link
Copy Markdown
Contributor Author

The versions aren't synchronized, which is the reason for

But to ensure I understand you correctly: you wish to ensure that dependencies in this repository use the exact same versions as dependencies in cosmwasm?

@chipshort

chipshort commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

Yes. To be extra clear, the versions I want to keep in sync are the ones in libwasmvm/Cargo.lock. Those should be the same as the ones in https://github.com/CosmWasm/cosmwasm/blob/main/Cargo.lock (or the lock file of version of cosmwasm we are using in libwasmvm, since we are not necessarily always using cosmwasm's main branch).
The PR you linked is about something completely different.

This is currently done by running cargo update manually in both at the same time.

@faddat

faddat commented Apr 17, 2025

Copy link
Copy Markdown
Contributor Author

oh great! I'll make prs for both!

@faddat

faddat commented Apr 17, 2025

Copy link
Copy Markdown
Contributor Author

once this PR is accepted:

CosmWasm/cosmwasm#2451

I will work on this PR again and get it all set :)

@faddat faddat closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants