Skip to content

refactor(notes): use non-monotonic ULIDs for note ids #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickAldewereld wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(notes): use non-monotonic ULIDs for note ids #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/app-server/src/modules/shared/utils/random.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ import { ulidFactory } from 'ulid-workers';

export { generateId };

const createUlid = ulidFactory();
// monotonic: false — in monotonic mode ids created within the same millisecond
// are a deterministic +1 of the previous random suffix instead of fresh entropy,
// making burst-created ids partly predictable. We don't need sortability for a
// capability id, so keep the full 80 bits of randomness per id.
const createUlid = ulidFactory({ monotonic: false });

function generateId() {
return createUlid().toLowerCase();
Expand Down