fix(ci): avoid shell injection from workflow_dispatch input#476
Open
NickAldewereld wants to merge 2 commits into
Open
fix(ci): avoid shell injection from workflow_dispatch input#476NickAldewereld wants to merge 2 commits into
NickAldewereld wants to merge 2 commits into
Conversation
…polation
Interpolating ${{ github.event.inputs.release_version }} straight into a
run: script is the textbook shell-injection pattern; route it through an
env var and reference it as a shell variable instead.
…ocker job Third-party actions were referenced by mutable tags, so a retagged release would run unreviewed code with the workflow's token. Pin every action to a full commit SHA, matching the existing actions/checkout pin. The workflow also granted packages:write to all four jobs while only docker-release pushes images. Move it down to that job so the npm publish jobs run without registry write access.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cd-docker-release.yamlinterpolates aworkflow_dispatchinput straight into arun:script:That is the textbook shell-injection pattern. It requires write access to trigger, so the risk is self-inflicted only, but it's easy to fix by routing the value through an
env:var and referencing it as a shell variable instead.