fix(ai): save all modified model defaults together - #304
Open
Cypher-Aura-19 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Each scope stored its pending selection inside
ScopeDetail, which was remounted whenever the selected scope changed. This discarded unsaved selections.The save handler also accepted and persisted only the currently selected scope, so there was no way to submit changes across Site, Content, Data, and Plugins together.
Changes
DefaultsTabTesting
bun test src/admin/pages/ai/tabs/DefaultsTab.test.tsxbun run lintbun run buildgit diff --checkThe full test suite has 207 failures on this branch. A clean
upstream/mainbaseline produced the same 207 failures:No new full-suite failures were introduced by this change.
Checklist
Closes #290