Skip to content

🎨 Palette: [preset λ²„νŠΌ ν™œμ„±ν™” μƒνƒœ μΆ”κ°€]#141

Open
seonghobae wants to merge 1 commit into
mainfrom
palette-preset-active-states-13978458133985360539
Open

🎨 Palette: [preset λ²„νŠΌ ν™œμ„±ν™” μƒνƒœ μΆ”κ°€]#141
seonghobae wants to merge 1 commit into
mainfrom
palette-preset-active-states-13978458133985360539

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

🎨 Palette: [preset λ²„νŠΌ ν™œμ„±ν™” μƒνƒœ μΆ”κ°€]

πŸ’‘ What: saas_web.py의 μš©λŸ‰ 프리셋 λ²„νŠΌ(.preset-btn)에 aria-pressed 속성과 ν™œμ„±ν™” μ‹œκ° 효과λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: μ‚¬μš©μžκ°€ μ–΄λ–€ 프리셋을 μ„ νƒν–ˆλŠ”μ§€ μ‹œκ°μ μœΌλ‘œ μ¦‰μ‹œ ν™•μΈν•˜κΈ° μ–΄λ ΅κ³ , 슀크린 리더 μ‚¬μš©μžμ—κ²Œ ν˜„μž¬ 선택 μƒνƒœκ°€ μ „λ‹¬λ˜μ§€ μ•ŠλŠ” 문제λ₯Ό ν•΄κ²°ν•©λ‹ˆλ‹€.
β™Ώ Accessibility: aria-pressed μƒνƒœλ₯Ό 톡해 슀크린 리더가 ν™œμ„±ν™”λœ λ²„νŠΌμ„ 인식할 수 있게 λ˜μ—ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 13978458133985360539 started by @seonghobae

πŸ’‘ What: `saas_web.py`의 μš©λŸ‰ 프리셋 λ²„νŠΌ(`.preset-btn`)에 `aria-pressed` 속성과 ν™œμ„±ν™” μ‹œκ° 효과λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: μ‚¬μš©μžκ°€ μ–΄λ–€ 프리셋을 μ„ νƒν–ˆλŠ”μ§€ μ‹œκ°μ μœΌλ‘œ μ¦‰μ‹œ ν™•μΈν•˜κΈ° μ–΄λ ΅κ³ , 슀크린 리더 μ‚¬μš©μžμ—κ²Œ ν˜„μž¬ 선택 μƒνƒœκ°€ μ „λ‹¬λ˜μ§€ μ•ŠλŠ” 문제λ₯Ό ν•΄κ²°ν•©λ‹ˆλ‹€.
β™Ώ Accessibility: `aria-pressed` μƒνƒœλ₯Ό 톡해 슀크린 리더가 ν™œμ„±ν™”λœ λ²„νŠΌμ„ 인식할 수 있게 λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 1, 2026 17:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an accessible β€œactive/selected” state for the target-bytes preset buttons in the SaaS web UI by introducing aria-pressed state management and corresponding styling.

Changes:

  • Add CSS styling for .preset-btn[aria-pressed="true"] to visually indicate the active preset.
  • Add data-value and initial aria-pressed="false" to preset buttons.
  • Update the target_bytes input handler to dynamically toggle aria-pressed on preset buttons based on the input value.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
saas_web.py Adds aria-pressed + active styling and JS state syncing for preset buttons tied to target_bytes.
.jules/palette.md Documents the accessibility/UX learning and recommended pattern for active preset buttons.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread saas_web.py
Comment on lines 91 to +94
.preset-container { margin-top: 8px; display: flex; gap: 8px; flex-wrap: wrap; }
.preset-btn { padding: 4px 8px; font-size: 0.85em; background-color: #e9ecef; color: #495057; border: 1px solid #ced4da; border-radius: 4px; cursor: pointer; }
.preset-btn:hover { background-color: #dde2e6; color: #212529; }
.preset-btn[aria-pressed="true"] { background-color: #0056b3; color: white; border-color: #004085; }

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head evidence but found unresolved reviewer or review-agent threads before approval.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved reviewer thread blocks automated approval

  • Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human or review-agent thread evidence on the current pull request.
  • Root cause: Reviewer and review-agent feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
  • Fix: Address or resolve the listed reviewer thread(s), then re-run OpenCode on the current head.
  • Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE, including bot review agents other than OpenCode itself.

Review thread evidence

Latest unresolved reviewer thread evidence

saas_web.py line 94

  • Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-01T17:18:17Z

  • Comment URL: #141 (comment)

  • Comment excerpt: The global 'button:hover:not(:disabled)' rule has higher specificity than '.preset-btn:hover' / '.preset-btn[aria-pressed="true"]' (because it includes an element selector), so preset buttons will still inherit the global hover background when hovered. That can mask the intended preset hover and can also make the pressed visual state appear inconsistent on hover. Excluding '.preset-btn' from the global hover rule keeps preset buttons fully controlled by their own hover/pressed styles.

  • Result: REQUEST_CHANGES

  • Reason: unresolved reviewer or review-agent thread(s) were present before approval.

  • Head SHA: e4d2be67ae33bdf0a1081629c3127ef2bbb1a8df

  • Workflow run: 28535069022

  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]
Loading

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: e4d2be67ae33bdf0a1081629c3127ef2bbb1a8df
  • Workflow run: 28535069022
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode reviewed the current-head evidence but found unresolved reviewer or review-agent threads before approval.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved reviewer thread blocks automated approval

  • Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human or review-agent thread evidence on the current pull request.
  • Root cause: Reviewer and review-agent feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
  • Fix: Address or resolve the listed reviewer thread(s), then re-run OpenCode on the current head.
  • Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE, including bot review agents other than OpenCode itself.

Review thread evidence

Latest unresolved reviewer thread evidence

saas_web.py line 94

  • Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-01T17:18:17Z

  • Comment URL: 🎨 Palette: [preset λ²„νŠΌ ν™œμ„±ν™” μƒνƒœ μΆ”κ°€]Β #141 (comment)

  • Comment excerpt: The global 'button:hover:not(:disabled)' rule has higher specificity than '.preset-btn:hover' / '.preset-btn[aria-pressed="true"]' (because it includes an element selector), so preset buttons will still inherit the global hover background when hovered. That can mask the intended preset hover and can also make the pressed visual state appear inconsistent on hover. Excluding '.preset-btn' from the global hover rule keeps preset buttons fully controlled by their own hover/pressed styles.

  • Result: REQUEST_CHANGES

  • Reason: unresolved reviewer or review-agent thread(s) were present before approval.

  • Head SHA: e4d2be67ae33bdf0a1081629c3127ef2bbb1a8df

  • Workflow run: 28535069022

  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants