π¨ Palette: [preset λ²νΌ νμ±ν μν μΆκ°]#141
Conversation
π‘ What: `saas_web.py`μ μ©λ ν리μ λ²νΌ(`.preset-btn`)μ `aria-pressed` μμ±κ³Ό νμ±ν μκ° ν¨κ³Όλ₯Ό μΆκ°νμ΅λλ€. π― Why: μ¬μ©μκ° μ΄λ€ ν리μ μ μ ννλμ§ μκ°μ μΌλ‘ μ¦μ νμΈνκΈ° μ΄λ ΅κ³ , μ€ν¬λ¦° 리λ μ¬μ©μμκ² νμ¬ μ ν μνκ° μ λ¬λμ§ μλ λ¬Έμ λ₯Ό ν΄κ²°ν©λλ€. βΏ Accessibility: `aria-pressed` μνλ₯Ό ν΅ν΄ μ€ν¬λ¦° 리λκ° νμ±νλ λ²νΌμ μΈμν μ μκ² λμμ΅λλ€.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Adds an accessible βactive/selectedβ state for the target-bytes preset buttons in the SaaS web UI by introducing aria-pressed state management and corresponding styling.
Changes:
- Add CSS styling for
.preset-btn[aria-pressed="true"]to visually indicate the active preset. - Add
data-valueand initialaria-pressed="false"to preset buttons. - Update the
target_bytesinput handler to dynamically togglearia-pressedon preset buttons based on the input value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
saas_web.py |
Adds aria-pressed + active styling and JS state syncing for preset buttons tied to target_bytes. |
.jules/palette.md |
Documents the accessibility/UX learning and recommended pattern for active preset buttons. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .preset-container { margin-top: 8px; display: flex; gap: 8px; flex-wrap: wrap; } | ||
| .preset-btn { padding: 4px 8px; font-size: 0.85em; background-color: #e9ecef; color: #495057; border: 1px solid #ced4da; border-radius: 4px; cursor: pointer; } | ||
| .preset-btn:hover { background-color: #dde2e6; color: #212529; } | ||
| .preset-btn[aria-pressed="true"] { background-color: #0056b3; color: white; border-color: #004085; } |
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head evidence but found unresolved reviewer or review-agent threads before approval.
Findings
1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved reviewer thread blocks automated approval
- Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human or review-agent thread evidence on the current pull request.
- Root cause: Reviewer and review-agent feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
- Fix: Address or resolve the listed reviewer thread(s), then re-run OpenCode on the current head.
- Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE, including bot review agents other than OpenCode itself.
Review thread evidence
Latest unresolved reviewer thread evidence
saas_web.py line 94
-
Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-01T17:18:17Z
-
Comment URL: #141 (comment)
-
Comment excerpt: The global 'button:hover:not(:disabled)' rule has higher specificity than '.preset-btn:hover' / '.preset-btn[aria-pressed="true"]' (because it includes an element selector), so preset buttons will still inherit the global hover background when hovered. That can mask the intended preset hover and can also make the pressed visual state appear inconsistent on hover. Excluding '.preset-btn' from the global hover rule keeps preset buttons fully controlled by their own hover/pressed styles.
-
Result: REQUEST_CHANGES
-
Reason: unresolved reviewer or review-agent thread(s) were present before approval.
-
Head SHA:
e4d2be67ae33bdf0a1081629c3127ef2bbb1a8df -
Workflow run: 28535069022
-
Workflow attempt: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode reviewed the current-head evidence but found unresolved reviewer or review-agent threads before approval. Findings1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved reviewer thread blocks automated approval
Review thread evidenceLatest unresolved reviewer thread evidence
|
π¨ Palette: [preset λ²νΌ νμ±ν μν μΆκ°]
π‘ What:
saas_web.pyμ μ©λ ν리μ λ²νΌ(.preset-btn)μaria-pressedμμ±κ³Ό νμ±ν μκ° ν¨κ³Όλ₯Ό μΆκ°νμ΅λλ€.π― Why: μ¬μ©μκ° μ΄λ€ ν리μ μ μ ννλμ§ μκ°μ μΌλ‘ μ¦μ νμΈνκΈ° μ΄λ ΅κ³ , μ€ν¬λ¦° 리λ μ¬μ©μμκ² νμ¬ μ ν μνκ° μ λ¬λμ§ μλ λ¬Έμ λ₯Ό ν΄κ²°ν©λλ€.
βΏ Accessibility:
aria-pressedμνλ₯Ό ν΅ν΄ μ€ν¬λ¦° 리λκ° νμ±νλ λ²νΌμ μΈμν μ μκ² λμμ΅λλ€.PR created automatically by Jules for task 13978458133985360539 started by @seonghobae