Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,7 @@
## 2025-02-15 - Replace Array.from(map.values()).map with a for...of loop
**Learning:** Using `Array.from(map.values()).map(...)` creates an unnecessary intermediate array which wastes memory allocation and garbage collection time, particularly for frequently re-rendered components handling large collections.
**Action:** Use a `for...of` loop over `map.values()` to iterate and push mapped elements directly into the final array for O(1) memory and avoiding intermediate array allocations.

## 2026-07-04 - Short-circuit extremum bound search
**Learning:** Using `.reduce()` unconditionally to find a minimum or maximum value with a known absolute bound incurs O(N) overhead.
**Action:** Replace `.reduce()` with a `for...of` loop and an early `break` when searching for a bounded extremum to transform an unconditional O(N) operation into one that can short-circuit.
Binary file added apps/desktop/src-tauri/icons/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 8 additions & 1 deletion apps/desktop/src-tauri/tauri.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@
},
"bundle": {
"active": true,
"targets": "all"
"targets": "all",
"icon": [
"icons/32x32.png",
"icons/128x128.png",
"icons/[email protected]",
"icons/icon.icns",
"icons/icon.ico"
]
}
}
27 changes: 27 additions & 0 deletions apps/desktop/src/App.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,33 @@ describe("App", () => {
expect(screen.getAllByText(/2 sections/i).length).toBeGreaterThan(0);
});

it("summarizes confidence with early exit on low confidence section", async () => {
const loadedProject = succeededResult().result;
// By adding a "low" confidence section and then another one, we ensure the loop
// encounters the "low" and breaks early, covering that explicit logic branch.
loadedProject.sections.push({
...loadedProject.sections[0],
id: "bridge-1",
label: "bridge",
confidence: { level: "low", source: "model", notes: "Difficult section." }
});
loadedProject.sections.push({
...loadedProject.sections[0],
id: "outro-1",
label: "outro",
confidence: { level: "high", source: "model", notes: "Easy outro." }
});
mockLoadProject.mockResolvedValueOnce(loadedProject);
render(<App />);

fireEvent.click(screen.getByRole("button", { name: /open project/i }));

await waitFor(() => {
expect(screen.getByText(/^Low$/i)).toBeTruthy();
});
expect(screen.getAllByText(/3 sections/i).length).toBeGreaterThan(0);
});

it("selects a local audio source and starts a local-audio analysis job", async () => {
tauriInvoke
.mockResolvedValueOnce(bootstrapResponse())
Expand Down
21 changes: 13 additions & 8 deletions apps/desktop/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,20 @@ function MetricCard({
function ConfidenceMetric({ song }: { song: RehearsalSong | null }) {
const sectionCount = song?.sections.length ?? 0;
const confidenceOrder = { high: 3, medium: 2, low: 1 } as const;
const lowestConfidence = song?.sections.reduce<RehearsalSong["sections"][number]["confidence"]["level"] | null>(
(current, section) => {
if (!current || confidenceOrder[section.confidence.level] < confidenceOrder[current]) {
return section.confidence.level;

let lowestConfidence: RehearsalSong["sections"][number]["confidence"]["level"] | null = null;
// O(N) operation with early short-circuit for performance
if (song?.sections) {
for (const section of song.sections) {
if (!lowestConfidence || confidenceOrder[section.confidence.level] < confidenceOrder[lowestConfidence]) {
lowestConfidence = section.confidence.level;
}
return current;
},
null
);
if (lowestConfidence === "low") {
break;
}
}
}

const confidence = lowestConfidence ? `${lowestConfidence[0].toUpperCase()}${lowestConfidence.slice(1)}` : "Ready";
const detail = sectionCount > 0 ? `${sectionCount} section${sectionCount === 1 ? "" : "s"}` : "Local analysis";

Expand Down
Loading