fix: 데스크톱 쉘 카피 현지화#545
Open
seonghobae wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Hardcoded desktop shell copy (nav/shell/status/header/metric cards) is moved into the existing i18n contract, plus a regression test ensuring the buyer-demo shell renders in Korean under ko-KR.
Changes:
- Added new shell/navigation/status/metric translation keys to
enandkocommon locale files - Updated
App.tsxUI strings to use the translator (t(...)) instead of inline English copy - Added a Vitest regression test for Korean localized shell surfaces
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| apps/desktop/src/locales/ko/common.json | Adds Korean translations for newly externalized shell/navigation/status/metric copy |
| apps/desktop/src/locales/en/common.json | Adds English translations for newly externalized shell/navigation/status/metric copy |
| apps/desktop/src/App.tsx | Replaces hardcoded strings with i18n keys across shell/nav/status/metrics and localizes error prefixes |
| apps/desktop/src/App.test.tsx | Adds regression test to confirm ko-KR renders Korean shell copy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "importYoutube": "Import YouTube", | ||
| "importingYoutube": "Importing...", | ||
| "youtubeImportFailed": "Failed to import YouTube URL." | ||
| "youtubeImportFailed": "Failed to import YouTube URL.", |
| "importYoutube": "유튜브 가져오기", | ||
| "importingYoutube": "가져오는 중...", | ||
| "youtubeImportFailed": "유튜브 URL 가져오기에 실패했습니다." | ||
| "youtubeImportFailed": "유튜브 URL 가져오기에 실패했습니다.", |
Comment on lines
56
to
66
| const NAV_ITEMS = [ | ||
| { label: "Workspace", icon: Home, active: true }, | ||
| { label: "Import", icon: Upload, active: false }, | ||
| { label: "Export", icon: Save, active: false }, | ||
| { label: "Sections", icon: ListMusic, active: false }, | ||
| { label: "Roles", icon: Users, active: false }, | ||
| { label: "Stem Lab", icon: AudioWaveform, active: false }, | ||
| { label: "Cues", icon: Sparkles, active: false }, | ||
| { label: "Transpose", icon: SlidersHorizontal, active: false }, | ||
| { label: "Notes", icon: FileMusic, active: false } | ||
| { labelKey: "navWorkspace", icon: Home, active: true }, | ||
| { labelKey: "navImport", icon: Upload, active: false }, | ||
| { labelKey: "navExport", icon: Save, active: false }, | ||
| { labelKey: "navSections", icon: ListMusic, active: false }, | ||
| { labelKey: "navRoles", icon: Users, active: false }, | ||
| { labelKey: "navStemLab", icon: AudioWaveform, active: false }, | ||
| { labelKey: "navCues", icon: Sparkles, active: false }, | ||
| { labelKey: "navTranspose", icon: SlidersHorizontal, active: false }, | ||
| { labelKey: "navNotes", icon: FileMusic, active: false } | ||
| ] as const; |
Comment on lines
+505
to
+507
| <nav aria-label={t("primaryRehearsalViewsAriaLabel")} className="space-y-2"> | ||
| {NAV_ITEMS.map(({ labelKey, icon: Icon, active }) => { | ||
| const label = t(labelKey as TranslationKey); |
Comment on lines
+180
to
+188
| function sectionCountDetail(t: ReturnType<typeof createTranslator>, sectionCount: number): string { | ||
| if (sectionCount === 0) { | ||
| return t("metricConfidenceLocalAnalysis"); | ||
| } | ||
| if (sectionCount === 1) { | ||
| return `1 ${t("metricConfidenceSectionSingular")}`; | ||
| } | ||
| return `${sectionCount} ${t("metricConfidenceSectionPlural")}`; | ||
| } |
Copilot stopped reviewing on behalf of
seonghobae due to an error
July 3, 2026 02:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
ko-KR환경에서 구매자 데모 첫 화면의 주요 쉘 카피가 한국어로 렌더되는 회귀 테스트를 추가했습니다.20억 KRW sale-readiness 연결
검증
npm ci(Node 24 로컬 엔진 경고만 발생: repo requires >=22.13 <23)npm --workspace @bandscope/desktop run typechecknpm --workspace @bandscope/desktop exec -- vitest run src/App.test.tsx src/i18n/index.test.ts(66 tests)npm --workspace @bandscope/desktop run lintnpm --workspace @bandscope/desktop run buildpython3 scripts/checks/verify_supply_chain.pygit diff --check