Skip to content

🎨 Palette: YouTube URL μž…λ ₯ ν•„λ“œ maxLength 속성 μΆ”κ°€ #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

🎨 Palette: YouTube URL μž…λ ₯ ν•„λ“œ maxLength 속성 μΆ”κ°€ #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/desktop/src/App.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,4 +1433,10 @@ describe("App", () => {
expect(settingsSpan).toHaveAttribute("tabIndex", "0");
expect(settingsSpan).toHaveAttribute("role", "button");
});

it("enforces a maximum length on the YouTube URL input", () => {
render(<App />);
const input = screen.getByPlaceholderText(/YouTube URL.../i);
expect(input).toHaveAttribute("maxLength", "2048");
});
Comment on lines +1437 to +1441
});
1 change: 1 addition & 0 deletions apps/desktop/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,7 @@ export function App() {
value={youtubeUrl}
onChange={(e) => setYoutubeUrl(e.target.value)}
disabled={analysisInFlight || isStarting || isImporting}
maxLength={2048}
className="h-10 flex-1 border-0 bg-transparent text-slate-100 placeholder:text-slate-500 focus-visible:ring-cyan-300"
aria-label="YouTube URL"
/>
Expand Down