π§ͺ [testing improvement] Add comprehensive tests for SectionRoadmap#394
π§ͺ [testing improvement] Add comprehensive tests for SectionRoadmap#394seonghobae wants to merge 6 commits into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Evidence
Python project dependencies (services/analysis-engine)
Python coverage with missing-line report (services/analysis-engine)
Python docstring coverage
JavaScript/TypeScript dependencies (npm ci)
Repository docstring coverage
JavaScript/TypeScript test coverage |
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds a broad set of tests to fully exercise SectionRoadmap behaviors, targeting previously uncovered branches and edge cases.
Changes:
- Added chord-editing tests (cancel/empty/whitespace, missing targets, disabled edit behavior).
- Added rendering tests for priority icons, confidence badges, overlap warnings, and role filtering.
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
OpenCode reviewed the current-head evidence but found unresolved human review threads before approval.
- Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human review thread evidence on the current pull request.
- Root cause: Human review feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
- Fix: Address or resolve the listed human review thread(s), then re-run OpenCode on the current head.
- Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE.
Review thread evidence
Latest unresolved human review thread evidence
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 86
- Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:57Z
- Comment URL: #394 (comment)
- Comment excerpt: The test title claims it βcalls the handler directlyβ, but itβs dispatching a click event on the button. This is misleading and also overlaps heavily with the prior βdisabledβ test; consider either (a) renaming the test to reflect the UI-level behavior being asserted, or (b) dropping this test if the disabled-button test already guarantees the intended branch is covered.
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 156
- Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:57Z
- Comment URL: #394 (comment)
- Comment excerpt:
global.structuredClonemay beundefinedin some test environments, causingoriginalStructuredClone(val)to throw and making this test non-portable. Prefer using a safe clone fallback in the mock implementation (e.g., iforiginalStructuredCloneis missing, use a deterministic clone approach suitable for this test data) so the test is robust across runners.
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 55
- Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:58Z
- Comment URL: #394 (comment)
- Comment excerpt: Multiple tests create
vi.spyOn(window, "prompt")but donβt explicitly restore it. If this file doesnβt already have aafterEach(() => vi.restoreAllMocks()), the spies can leak between tests and cause order-dependent failures. Consider restoring the spy per test (or adding a sharedafterEach) to keep isolation.
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 73
-
Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:58Z
-
Comment URL: #394 (comment)
-
Comment excerpt: If
@testing-library/jest-domis available in this repo, preferexpect(button).toBeDisabled()which more accurately reflects disabled semantics (and yields clearer failure output) than checking for a raw attribute. -
Result: REQUEST_CHANGES
-
Reason: unresolved human review thread(s) were present before approval.
-
Head SHA:
8b64d5d2232f22f2631e74836e5dba344eed71de -
Workflow run: 28148434602
-
Workflow attempt: 1
There was a problem hiding this comment.
OpenCode reviewed the current-head evidence but found unresolved human review threads before approval.
- Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human review thread evidence on the current pull request.
- Root cause: Human review feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
- Fix: Address or resolve the listed human review thread(s), then re-run OpenCode on the current head.
- Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE.
Review thread evidence
Latest unresolved human review thread evidence
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 86
- Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:57Z
- Comment URL: #394 (comment)
- Comment excerpt: The test title claims it βcalls the handler directlyβ, but itβs dispatching a click event on the button. This is misleading and also overlaps heavily with the prior βdisabledβ test; consider either (a) renaming the test to reflect the UI-level behavior being asserted, or (b) dropping this test if the disabled-button test already guarantees the intended branch is covered.
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 156
- Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:57Z
- Comment URL: #394 (comment)
- Comment excerpt:
global.structuredClonemay beundefinedin some test environments, causingoriginalStructuredClone(val)to throw and making this test non-portable. Prefer using a safe clone fallback in the mock implementation (e.g., iforiginalStructuredCloneis missing, use a deterministic clone approach suitable for this test data) so the test is robust across runners.
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 55
- Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:58Z
- Comment URL: #394 (comment)
- Comment excerpt: Multiple tests create
vi.spyOn(window, "prompt")but donβt explicitly restore it. If this file doesnβt already have aafterEach(() => vi.restoreAllMocks()), the spies can leak between tests and cause order-dependent failures. Consider restoring the spy per test (or adding a sharedafterEach) to keep isolation.
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 73
-
Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:58Z
-
Comment URL: #394 (comment)
-
Comment excerpt: If
@testing-library/jest-domis available in this repo, preferexpect(button).toBeDisabled()which more accurately reflects disabled semantics (and yields clearer failure output) than checking for a raw attribute. -
Result: REQUEST_CHANGES
-
Reason: unresolved human review thread(s) were present before approval.
-
Head SHA:
2a43e18337c0e96f26293c0382ac866836989649 -
Workflow run: 28156443525
-
Workflow attempt: 1
There was a problem hiding this comment.
OpenCode reviewed the current-head evidence but found unresolved human review threads before approval.
- Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human review thread evidence on the current pull request.
- Root cause: Human review feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
- Fix: Address or resolve the listed human review thread(s), then re-run OpenCode on the current head.
- Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE.
Review thread evidence
Latest unresolved human review thread evidence
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 86
- Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:57Z
- Comment URL: #394 (comment)
- Comment excerpt: The test title claims it βcalls the handler directlyβ, but itβs dispatching a click event on the button. This is misleading and also overlaps heavily with the prior βdisabledβ test; consider either (a) renaming the test to reflect the UI-level behavior being asserted, or (b) dropping this test if the disabled-button test already guarantees the intended branch is covered.
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 156
- Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:57Z
- Comment URL: #394 (comment)
- Comment excerpt:
global.structuredClonemay beundefinedin some test environments, causingoriginalStructuredClone(val)to throw and making this test non-portable. Prefer using a safe clone fallback in the mock implementation (e.g., iforiginalStructuredCloneis missing, use a deterministic clone approach suitable for this test data) so the test is robust across runners.
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 55
- Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:58Z
- Comment URL: #394 (comment)
- Comment excerpt: Multiple tests create
vi.spyOn(window, "prompt")but donβt explicitly restore it. If this file doesnβt already have aafterEach(() => vi.restoreAllMocks()), the spies can leak between tests and cause order-dependent failures. Consider restoring the spy per test (or adding a sharedafterEach) to keep isolation.
apps/desktop/src/features/workspace/SectionRoadmap.test.tsx line 73
-
Latest human comment: @copilot-pull-request-reviewer at 2026-06-25T00:52:58Z
-
Comment URL: #394 (comment)
-
Comment excerpt: If
@testing-library/jest-domis available in this repo, preferexpect(button).toBeDisabled()which more accurately reflects disabled semantics (and yields clearer failure output) than checking for a raw attribute. -
Result: REQUEST_CHANGES
-
Reason: unresolved human review thread(s) were present before approval.
-
Head SHA:
9655099731ea74b5fe3f394df5e45d6f33f43912 -
Workflow run: 28160037811
-
Workflow attempt: 1
seonghobae
force-pushed
the
jules-3375919807166646025-caa6a7c3
branch
from
9655099 to
52b2eaf
Compare
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head evidence but cannot approve because required coverage evidence did not pass.
Findings
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove 100% test and docstring coverage
-
Problem: The OpenCode approval path reached an APPROVE control result while the separate coverage-evidence job result was
failure. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves both test coverage and docstring coverage at 100%, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, unsupported-tooling, or partial coverage evidence is a blocker.
-
Fix: Install or configure the repository coverage/docstring coverage tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith 100% or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so 100% test/docstring coverage was not proven for current head52b2eaf1335ef75cae36a35d91ad9c247e4ea4b0. -
Head SHA:
52b2eaf1335ef75cae36a35d91ad9c247e4ea4b0 -
Workflow run: 28329767132
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
52b2eaf1335ef75cae36a35d91ad9c247e4ea4b0 - Required test coverage: 100%
- Required docstring coverage: 100%
Python project dependencies (services/analysis-engine)
Using CPython 3.12.3 interpreter at: /usr/bin/python3.12
Creating virtual environment at: services/analysis-engine/.venv
Resolved 49 packages in 0.72ms
Building bandscope-analysis @ file:///home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine
Downloading soundfile (1.3MiB)
Downloading yt-dlp (3.0MiB)
Downloading scikit-learn (8.5MiB)
Downloading ruff (10.7MiB)
Downloading mypy (13.0MiB)
Downloading numpy (15.8MiB)
Downloading scipy (33.6MiB)
Downloading pygments (1.2MiB)
Downloading numba (3.6MiB)
Downloading llvmlite (53.7MiB)
Downloaded soundfile
Downloaded pygments
Built bandscope-analysis @ file:///home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine
Downloaded numba
Downloaded ruff
Downloaded scikit-learn
Downloaded yt-dlp
Downloaded numpy
Downloaded llvmlite
Downloaded scipy
Downloaded mypy
Prepared 44 packages in 2.18s
Installed 44 packages in 76ms
+ audioread==3.1.0
+ bandit==1.9.4
+ bandscope-analysis==0.1.0 (from file:///home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine)
+ certifi==2026.2.25
+ cffi==2.0.0
+ charset-normalizer==3.4.6
+ coverage==7.13.4
+ decorator==5.2.1
+ idna==3.18
+ iniconfig==2.3.0
+ joblib==1.5.3
+ lazy-loader==0.5
+ librosa==0.11.0
+ librt==0.8.1
+ llvmlite==0.45.1
+ markdown-it-py==4.0.0
+ mdurl==0.1.2
+ msgpack==1.2.1
+ mypy==1.19.1
+ mypy-extensions==1.1.0
+ numba==0.62.1
+ numpy==2.3.5
+ packaging==26.0
+ pathspec==1.0.4
+ platformdirs==4.9.4
+ pluggy==1.6.0
+ pooch==1.9.0
+ pycparser==3.0
+ pygments==2.20.0
+ pytest==9.0.3
+ pytest-cov==7.0.0
+ pyyaml==6.0.3
+ requests==2.33.0
+ rich==15.0.0
+ ruff==0.15.5
+ scikit-learn==1.8.0
+ scipy==1.17.1
+ soundfile==0.13.1
+ soxr==1.0.0
+ stevedore==5.7.0
+ threadpoolctl==3.6.0
+ typing-extensions==4.15.0
+ urllib3==2.7.0
+ yt-dlp==2026.6.9
- Result: PASS
Python test coverage (services/analysis-engine)
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-9.0.3, pluggy-1.6.0
rootdir: /home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine
configfile: pyproject.toml
plugins: cov-7.0.0
collected 441 items
tests/test_activity.py ........ [ 1%]
tests/test_anchors.py .... [ 2%]
tests/test_api.py ......................... [ 8%]
tests/test_chord_recognizer.py .................... [ 12%]
tests/test_chords.py ......................... [ 18%]
tests/test_cli.py ................. [ 22%]
tests/test_extractor.py ...... [ 23%]
tests/test_health.py . [ 24%]
tests/test_pipeline_integration.py ......... [ 26%]
tests/test_pitch_tracker.py ............... [ 29%]
tests/test_priority.py ....... [ 31%]
tests/test_ranges.py ................... [ 35%]
tests/test_release_asset_selection.py ........ [ 37%]
tests/test_release_metadata.py ....... [ 38%]
tests/test_release_packaging.py ......... [ 40%]
tests/test_roles.py ....... [ 42%]
tests/test_roles_ml.py ... [ 43%]
tests/test_segmenter.py ..................... [ 47%]
tests/test_separation.py .................................. [ 55%]
tests/test_supply_chain_policy.py ...................................... [ 64%]
........................................................................ [ 80%]
..................................................... [ 92%]
tests/test_temporal.py ......... [ 94%]
tests/test_transcription.py ... [ 95%]
tests/test_tuning.py ..... [ 96%]
tests/test_youtube.py ................ [100%]
=============================== warnings summary ===============================
tests/test_pipeline_integration.py::test_pipeline_without_detected_sections_falls_back
tests/test_roles.py::test_role_extractor_falls_back_when_activity_detection_fails
/home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine/.venv/lib/python3.12/site-packages/librosa/core/pitch.py:103: UserWarning: Trying to estimate tuning from empty frequency set.
return pitch_tuning(
tests/test_roles.py::test_role_extractor_falls_back_when_activity_detection_fails
/home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine/.venv/lib/python3.12/site-packages/librosa/core/spectrum.py:266: UserWarning: n_fft=2048 is too large for input signal of length=100
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================ tests coverage ================================
_______________ coverage: platform linux, python 3.12.3-final-0 ________________
Name Stmts Miss Cover Missing
------------------------------------------------------------------------------------
src/bandscope_analysis/__init__.py 3 0 100%
src/bandscope_analysis/api.py 571 0 100%
src/bandscope_analysis/chords/__init__.py 5 0 100%
src/bandscope_analysis/chords/analyzer.py 116 0 100%
src/bandscope_analysis/chords/capo.py 10 0 100%
src/bandscope_analysis/chords/chord_recognizer.py 192 0 100%
src/bandscope_analysis/chords/model.py 15 0 100%
src/bandscope_analysis/cli.py 68 0 100%
src/bandscope_analysis/health.py 7 0 100%
src/bandscope_analysis/ranges/__init__.py 4 0 100%
src/bandscope_analysis/ranges/analyzer.py 77 0 100%
src/bandscope_analysis/ranges/model.py 19 0 100%
src/bandscope_analysis/ranges/pitch_tracker.py 54 0 100%
src/bandscope_analysis/roles/__init__.py 4 0 100%
src/bandscope_analysis/roles/activity.py 59 0 100%
src/bandscope_analysis/roles/extractor.py 118 0 100%
src/bandscope_analysis/roles/model.py 58 0 100%
src/bandscope_analysis/roles/priority.py 13 0 100%
src/bandscope_analysis/roles/tuning.py 11 0 100%
src/bandscope_analysis/sections/__init__.py 6 0 100%
src/bandscope_analysis/sections/anchors.py 5 0 100%
src/bandscope_analysis/sections/extractor.py 38 0 100%
src/bandscope_analysis/sections/model.py 35 0 100%
src/bandscope_analysis/sections/segmenter.py 140 0 100%
src/bandscope_analysis/sections/utils.py 8 0 100%
src/bandscope_analysis/separation/__init__.py 4 0 100%
src/bandscope_analysis/separation/audio_separator.py 145 0 100%
src/bandscope_analysis/separation/model.py 31 0 100%
src/bandscope_analysis/separation/separator.py 34 0 100%
src/bandscope_analysis/temporal/__init__.py 3 0 100%
src/bandscope_analysis/temporal/analyzer.py 49 0 100%
src/bandscope_analysis/temporal/model.py 9 0 100%
src/bandscope_analysis/transcription/__init__.py 2 0 100%
src/bandscope_analysis/transcription/api.py 11 0 100%
src/bandscope_analysis/youtube.py 81 0 100%
------------------------------------------------------------------------------------
TOTAL 2005 0 100%
Required test coverage of 100% reached. Total coverage: 100.00%
================== 441 passed, 3 warnings in 95.08s (0:01:35) ==================
- Result: PASS
Python docstring coverage
- Result: DEFERRED
- Reason: package.json defines check:python-docstrings; repository-owned docstring coverage runs after package dependency setup.
JavaScript/TypeScript dependencies (npm ci)
added 272 packages, and audited 275 packages in 7s
71 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
- Result: PASS
Repository docstring coverage
> [email protected] check:python-docstrings
> sh -c 'cd services/analysis-engine && uv run ruff check src tests ../../scripts --select D100,D101,D102,D103,D104,D105,D106,D107'
All checks passed!
- Result: PASS
JavaScript/TypeScript test coverage
> [email protected] test
> npm run test --workspaces --if-present && sh -c 'cd services/analysis-engine && uv run pytest tests --cov=src/bandscope_analysis --cov-report=term-missing --cov-fail-under=100' --coverage
> @bandscope/[email protected] test
> node -e "require('node:fs').mkdirSync('coverage/.tmp', { recursive: true })" && vitest run --coverage
οΏ½[1mοΏ½[30mοΏ½[46m RUN οΏ½[49mοΏ½[39mοΏ½[22m οΏ½[36mv4.1.9 οΏ½[39mοΏ½[90m/home/runner/work/bandscope/bandscope/pr-head/apps/desktopοΏ½[39m
οΏ½[2mCoverage enabled with οΏ½[22mοΏ½[33mv8οΏ½[39m
οΏ½[32mβοΏ½[39m src/lib/export.test.ts οΏ½[2m(οΏ½[22mοΏ½[2m17 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 18οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/lib/analysis.test.ts οΏ½[2m(οΏ½[22mοΏ½[2m14 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 26οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/features/workspace/Workspace.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m11 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[33m 1857οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[33mοΏ½[2mβοΏ½[22mοΏ½[39m enables bass transcription from selected role metadata rather than role id text οΏ½[33m 442οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/features/workspace/SectionRoadmap.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m10 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[33m 813οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[33mοΏ½[2mβοΏ½[22mοΏ½[39m uses localized copy for chord edit prompts and control labels οΏ½[33m 315οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/components/ui/ui-primitives.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m7 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[33m 399οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[33mοΏ½[2mβοΏ½[22mοΏ½[39m renders only custom progress children when supplied οΏ½[33m 301οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/i18n/index.test.ts οΏ½[2m(οΏ½[22mοΏ½[2m9 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 7οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/features/workspace/RoleSwitcher.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m4 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 257οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[31mβ―οΏ½[39m src/App.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m51 testsοΏ½[22mοΏ½[2m | οΏ½[22mοΏ½[31m1 failedοΏ½[39mοΏ½[2m)οΏ½[22mοΏ½[33m 14210οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[33mοΏ½[2mβοΏ½[22mοΏ½[39m renders the rehearsal cockpit shell before analysis starts οΏ½[33m 597οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[33mοΏ½[2mβοΏ½[22mοΏ½[39m renders the loaded song as a dark rehearsal command board οΏ½[33m 402οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[33mοΏ½[2mβοΏ½[22mοΏ½[39m renders a rehearsal song structure timeline from real section ranges οΏ½[33m 510οΏ½[2mmsοΏ½[22mοΏ½[39m
seonghobae
force-pushed
the
jules-3375919807166646025-caa6a7c3
branch
from
52b2eaf to
ed87cd1
Compare
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head bounded evidence and found no blocking issues.
Findings
No blocking findings.
Summary
Added 131 lines of tests for SectionRoadmap component covering chord editing, priority indicators, confidence badges, role filtering, and edge cases. All tests pass with 100% coverage. Verification posture: Linter/static: PASS, TDD/regression: PASS, Coverage: 100%, Docstring coverage: 100%, DAG: SectionRoadmap.test.tsx β Test coverage β Regression safety, PoC/execution: npm test passed, DDD/domain: Matches rehearsal domain model, CDD/context: Consistent with existing test patterns, Similar issues: None found, Standards search: N/A, Compatibility/convention: Follows project conventions, Breaking-change/backcompat: N/A, Performance: N/A, Developer experience: Improves maintainability, User experience: Ensures UI reliability
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including apps/desktop/src/features/workspace/SectionRoadmap.test.tsx.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence proves 100% test coverage.
Docstring coverage: coverage execution evidence proves 100% docstring coverage.
DAG: Change Flow DAG maps apps/desktop/src/features/workspace/SectionRoadmap.test.tsx through bounded evidence, review risk, and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, and current-head workflow evidence were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions and compatibility surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: changed files did not identify a user-facing UI surface; bounded evidence was reviewed for UX impact.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.
- Result: APPROVE
- Reason: Comprehensive test coverage added with no blockers found
- Head SHA:
ed87cd1603be58d19359b4acb7e0f1b823bf85d9 - Workflow run: 28333510620
- Workflow attempt: 1
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head evidence but cannot approve because required coverage evidence did not pass.
Findings
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The OpenCode approval path reached an APPROVE control result while the separate coverage-evidence job result was
cancelled. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
cancelled, so required test/docstring evidence was not proven for current headee36d380ff5e6ab32ee10943626f817e5bc6a6bd. -
Head SHA:
ee36d380ff5e6ab32ee10943626f817e5bc6a6bd -
Workflow run: 28367367713
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Change Flow DAG
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: SectionRoadmap.test.tsx"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: SectionRoadmap.test.tsx"]
R1 --> V1["required checks"]
β¦6646025-caa6a7c3 # Conflicts: # apps/desktop/src/features/workspace/SectionRoadmap.test.tsx
β¦d Fix GitHub Actions token expiration during long checks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head7d990b9f6d20c8d2daaabe4a9d437956fe30864c. -
Head SHA:
7d990b9f6d20c8d2daaabe4a9d437956fe30864c -
Workflow run: 28503551251
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
7d990b9f6d20c8d2daaabe4a9d437956fe30864c - Required test evidence: supported repository test suites must pass.
- Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.
Python project dependencies (services/analysis-engine)
Using CPython 3.12.3 interpreter at: /usr/bin/python3.12
Creating virtual environment at: services/analysis-engine/.venv
Resolved 49 packages in 0.66ms
Building bandscope-analysis @ file:///home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine
Downloading yt-dlp (3.0MiB)
Downloading pygments (1.2MiB)
Downloading llvmlite (53.7MiB)
Downloading scikit-learn (8.5MiB)
Downloading scipy (33.6MiB)
Downloading numpy (15.8MiB)
Downloading soundfile (1.3MiB)
Downloading numba (3.6MiB)
Downloading ruff (10.7MiB)
Downloading mypy (13.0MiB)
Downloaded soundfile
Downloaded pygments
Built bandscope-analysis @ file:///home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine
Downloaded numba
Downloaded ruff
Downloaded yt-dlp
Downloaded scikit-learn
Downloaded numpy
Downloaded llvmlite
Downloaded scipy
Downloaded mypy
Prepared 44 packages in 2.13s
Installed 44 packages in 63ms
+ audioread==3.1.0
+ bandit==1.9.4
+ bandscope-analysis==0.1.0 (from file:///home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine)
+ certifi==2026.2.25
+ cffi==2.0.0
+ charset-normalizer==3.4.6
+ coverage==7.13.4
+ decorator==5.2.1
+ idna==3.18
+ iniconfig==2.3.0
+ joblib==1.5.3
+ lazy-loader==0.5
+ librosa==0.11.0
+ librt==0.8.1
+ llvmlite==0.45.1
+ markdown-it-py==4.0.0
+ mdurl==0.1.2
+ msgpack==1.2.1
+ mypy==1.19.1
+ mypy-extensions==1.1.0
+ numba==0.62.1
+ numpy==2.3.5
+ packaging==26.0
+ pathspec==1.0.4
+ platformdirs==4.9.4
+ pluggy==1.6.0
+ pooch==1.9.0
+ pycparser==3.0
+ pygments==2.20.0
+ pytest==9.0.3
+ pytest-cov==7.0.0
+ pyyaml==6.0.3
+ requests==2.33.0
+ rich==15.0.0
+ ruff==0.15.5
+ scikit-learn==1.8.0
+ scipy==1.17.1
+ soundfile==0.13.1
+ soxr==1.0.0
+ stevedore==5.7.0
+ threadpoolctl==3.6.0
+ typing-extensions==4.15.0
+ urllib3==2.7.0
+ yt-dlp==2026.6.9
- Result: PASS
Python coverage with missing-line report (services/analysis-engine)
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-9.0.3, pluggy-1.6.0
rootdir: /home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine
configfile: pyproject.toml
plugins: cov-7.0.0
collected 437 items
tests/test_activity.py ........ [ 1%]
tests/test_anchors.py .... [ 2%]
tests/test_api.py ......................... [ 8%]
tests/test_chord_recognizer.py .................... [ 13%]
tests/test_chords.py ......................... [ 18%]
tests/test_cli.py ................. [ 22%]
tests/test_health.py . [ 22%]
tests/test_pipeline_integration.py ......... [ 24%]
tests/test_pitch_tracker.py ............... [ 28%]
tests/test_priority.py ....... [ 29%]
tests/test_ranges.py ................... [ 34%]
tests/test_release_asset_selection.py ........ [ 36%]
tests/test_release_metadata.py ....... [ 37%]
tests/test_release_packaging.py ......... [ 39%]
tests/test_roles.py ....... [ 41%]
tests/test_roles_ml.py ... [ 42%]
tests/test_sections.py ... [ 42%]
tests/test_segmenter.py ..................... [ 47%]
tests/test_separation.py ................................. [ 55%]
tests/test_supply_chain_policy.py ...................................... [ 63%]
........................................................................ [ 80%]
..................................................... [ 92%]
tests/test_temporal.py ......... [ 94%]
tests/test_transcription.py ... [ 95%]
tests/test_tuning.py ..... [ 96%]
tests/test_youtube.py ................ [100%]
=============================== warnings summary ===============================
tests/test_pipeline_integration.py::test_pipeline_without_detected_sections_falls_back
tests/test_roles.py::test_role_extractor_falls_back_when_activity_detection_fails
/home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine/.venv/lib/python3.12/site-packages/librosa/core/pitch.py:103: UserWarning: Trying to estimate tuning from empty frequency set.
return pitch_tuning(
tests/test_roles.py::test_role_extractor_falls_back_when_activity_detection_fails
/home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine/.venv/lib/python3.12/site-packages/librosa/core/spectrum.py:266: UserWarning: n_fft=2048 is too large for input signal of length=100
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================== 437 passed, 3 warnings in 92.64s (0:01:32) ==================
Name Stmts Miss Cover Missing
------------------------------------------------------------------------------------
src/bandscope_analysis/__init__.py 3 0 100%
src/bandscope_analysis/api.py 571 0 100%
src/bandscope_analysis/chords/__init__.py 5 0 100%
src/bandscope_analysis/chords/analyzer.py 116 0 100%
src/bandscope_analysis/chords/capo.py 10 0 100%
src/bandscope_analysis/chords/chord_recognizer.py 192 0 100%
src/bandscope_analysis/chords/model.py 15 0 100%
src/bandscope_analysis/cli.py 68 0 100%
src/bandscope_analysis/health.py 7 0 100%
src/bandscope_analysis/ranges/__init__.py 4 0 100%
src/bandscope_analysis/ranges/analyzer.py 77 0 100%
src/bandscope_analysis/ranges/model.py 19 0 100%
src/bandscope_analysis/ranges/pitch_tracker.py 54 0 100%
src/bandscope_analysis/roles/__init__.py 4 0 100%
src/bandscope_analysis/roles/activity.py 59 0 100%
src/bandscope_analysis/roles/extractor.py 118 0 100%
src/bandscope_analysis/roles/model.py 58 0 100%
src/bandscope_analysis/roles/priority.py 13 0 100%
src/bandscope_analysis/roles/tuning.py 11 0 100%
src/bandscope_analysis/sections/__init__.py 6 0 100%
src/bandscope_analysis/sections/anchors.py 5 0 100%
src/bandscope_analysis/sections/extractor.py 38 0 100%
src/bandscope_analysis/sections/model.py 35 0 100%
src/bandscope_analysis/sections/segmenter.py 140 0 100%
src/bandscope_analysis/sections/utils.py 8 0 100%
src/bandscope_analysis/separation/__init__.py 4 0 100%
src/bandscope_analysis/separation/audio_separator.py 145 0 100%
src/bandscope_analysis/separation/model.py 31 0 100%
src/bandscope_analysis/separation/separator.py 34 0 100%
src/bandscope_analysis/temporal/__init__.py 3 0 100%
src/bandscope_analysis/temporal/analyzer.py 49 0 100%
src/bandscope_analysis/temporal/model.py 9 0 100%
src/bandscope_analysis/transcription/__init__.py 2 0 100%
src/bandscope_analysis/transcription/api.py 11 0 100%
src/bandscope_analysis/youtube.py 81 0 100%
------------------------------------------------------------------------------------
TOTAL 2005 0 100%
- Result: PASS
Python docstring coverage
- Result: DEFERRED
- Reason: package.json defines check:python-docstrings; repository-owned docstring coverage runs after package dependency setup.
JavaScript/TypeScript dependencies (npm ci)
added 272 packages, and audited 275 packages in 7s
71 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
- Result: PASS
Repository docstring coverage
> [email protected] check:python-docstrings
> sh -c 'cd services/analysis-engine && uv run ruff check src tests ../../scripts --select D100,D101,D102,D103,D104,D105,D106,D107'
All checks passed!
- Result: PASS
JavaScript/TypeScript test coverage
> [email protected] test
> npm run test --workspaces --if-present && sh -c 'cd services/analysis-engine && uv run pytest tests --cov=src/bandscope_analysis --cov-report=term-missing --cov-fail-under=100' --coverage
> @bandscope/[email protected] test
> node -e "require('node:fs').mkdirSync('coverage/.tmp', { recursive: true })" && vitest run --coverage
οΏ½[1mοΏ½[30mοΏ½[46m RUN οΏ½[49mοΏ½[39mοΏ½[22m οΏ½[36mv4.1.9 οΏ½[39mοΏ½[90m/home/runner/work/bandscope/bandscope/pr-head/apps/desktopοΏ½[39m
οΏ½[2mCoverage enabled with οΏ½[22mοΏ½[33mv8οΏ½[39m
οΏ½[32mβοΏ½[39m src/lib/export.test.ts οΏ½[2m(οΏ½[22mοΏ½[2m16 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 26οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/features/workspace/Workspace.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m11 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[33m 1862οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[33mοΏ½[2mβοΏ½[22mοΏ½[39m enables bass transcription from selected role metadata rather than role id text οΏ½[33m 456οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/features/workspace/SectionRoadmap.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m12 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[33m 1279οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[33mοΏ½[2mβοΏ½[22mοΏ½[39m uses localized copy for chord edit prompts and control labels οΏ½[33m 330οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/lib/analysis.test.ts οΏ½[2m(οΏ½[22mοΏ½[2m14 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 26οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/components/ui/ui-primitives.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m7 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 160οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/i18n/index.test.ts οΏ½[2m(οΏ½[22mοΏ½[2m9 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 9οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[90mstderrοΏ½[2m | src/App.test.tsxοΏ½[2m > οΏ½[22mοΏ½[2mAppοΏ½[2m > οΏ½[22mοΏ½[2mapplies pushed analysis status updates over the IPC event bridge
οΏ½[22mοΏ½[39mAn update to App inside a test was not wrapped in act(...).
When testing, code that causes React state updates should be wrapped into act(...):
act(() => {
/* fire events that update state */
});
/* assert on the output */
## Changed-File Evidence Map
```mermaid
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (21 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (21 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Workflow (13 files)"]
S2 --> I2["GitHub Actions review job"]
I2 --> R2["Review risk: Workflow (13 files)"]
R2 --> V2["actionlint plus required checks"]
Evidence --> S3["Docs (5 files)"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs (5 files)"]
R3 --> V3["docs review"]
Evidence --> S4["CI script (8 files)"]
S4 --> I4["review and security gate shell path"]
I4 --> R4["Review risk: CI script (8 files)"]
R4 --> V4["bash -n plus Strix self-test"]
Evidence --> S5["Test (5 files)"]
S5 --> I5["regression suite"]
I5 --> R5["Review risk: Test (5 files)"]
R5 --> V5["targeted test run"]
β¦d Fix GitHub Actions token expiration during long checks
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head32b141952cb774189bc3d8f2ca3f3349ce0dfd53. -
Head SHA:
32b141952cb774189bc3d8f2ca3f3349ce0dfd53 -
Workflow run: 28506078242
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
32b141952cb774189bc3d8f2ca3f3349ce0dfd53 - Required test evidence: supported repository test suites must pass.
- Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.
Python project dependencies (services/analysis-engine)
Using CPython 3.12.3 interpreter at: /usr/bin/python3.12
Creating virtual environment at: services/analysis-engine/.venv
Resolved 49 packages in 0.64ms
Building bandscope-analysis @ file:///home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine
Downloading mypy (13.0MiB)
Downloading pygments (1.2MiB)
Downloading numpy (15.8MiB)
Downloading scikit-learn (8.5MiB)
Downloading numba (3.6MiB)
Downloading scipy (33.6MiB)
Downloading ruff (10.7MiB)
Downloading soundfile (1.3MiB)
Downloading yt-dlp (3.0MiB)
Downloading llvmlite (53.7MiB)
Downloaded soundfile
Downloaded pygments
Built bandscope-analysis @ file:///home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine
Downloaded numba
Downloaded ruff
Downloaded scikit-learn
Downloaded yt-dlp
Downloaded numpy
Downloaded llvmlite
Downloaded scipy
Downloaded mypy
Prepared 44 packages in 2.15s
Installed 44 packages in 77ms
+ audioread==3.1.0
+ bandit==1.9.4
+ bandscope-analysis==0.1.0 (from file:///home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine)
+ certifi==2026.2.25
+ cffi==2.0.0
+ charset-normalizer==3.4.6
+ coverage==7.13.4
+ decorator==5.2.1
+ idna==3.18
+ iniconfig==2.3.0
+ joblib==1.5.3
+ lazy-loader==0.5
+ librosa==0.11.0
+ librt==0.8.1
+ llvmlite==0.45.1
+ markdown-it-py==4.0.0
+ mdurl==0.1.2
+ msgpack==1.2.1
+ mypy==1.19.1
+ mypy-extensions==1.1.0
+ numba==0.62.1
+ numpy==2.3.5
+ packaging==26.0
+ pathspec==1.0.4
+ platformdirs==4.9.4
+ pluggy==1.6.0
+ pooch==1.9.0
+ pycparser==3.0
+ pygments==2.20.0
+ pytest==9.0.3
+ pytest-cov==7.0.0
+ pyyaml==6.0.3
+ requests==2.33.0
+ rich==15.0.0
+ ruff==0.15.5
+ scikit-learn==1.8.0
+ scipy==1.17.1
+ soundfile==0.13.1
+ soxr==1.0.0
+ stevedore==5.7.0
+ threadpoolctl==3.6.0
+ typing-extensions==4.15.0
+ urllib3==2.7.0
+ yt-dlp==2026.6.9
- Result: PASS
Python coverage with missing-line report (services/analysis-engine)
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-9.0.3, pluggy-1.6.0
rootdir: /home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine
configfile: pyproject.toml
plugins: cov-7.0.0
collected 437 items
tests/test_activity.py ........ [ 1%]
tests/test_anchors.py .... [ 2%]
tests/test_api.py ......................... [ 8%]
tests/test_chord_recognizer.py .................... [ 13%]
tests/test_chords.py ......................... [ 18%]
tests/test_cli.py ................. [ 22%]
tests/test_health.py . [ 22%]
tests/test_pipeline_integration.py ......... [ 24%]
tests/test_pitch_tracker.py ............... [ 28%]
tests/test_priority.py ....... [ 29%]
tests/test_ranges.py ................... [ 34%]
tests/test_release_asset_selection.py ........ [ 36%]
tests/test_release_metadata.py ....... [ 37%]
tests/test_release_packaging.py ......... [ 39%]
tests/test_roles.py ....... [ 41%]
tests/test_roles_ml.py ... [ 42%]
tests/test_sections.py ... [ 42%]
tests/test_segmenter.py ..................... [ 47%]
tests/test_separation.py ................................. [ 55%]
tests/test_supply_chain_policy.py ...................................... [ 63%]
........................................................................ [ 80%]
..................................................... [ 92%]
tests/test_temporal.py ......... [ 94%]
tests/test_transcription.py ... [ 95%]
tests/test_tuning.py ..... [ 96%]
tests/test_youtube.py ................ [100%]
=============================== warnings summary ===============================
tests/test_pipeline_integration.py::test_pipeline_without_detected_sections_falls_back
tests/test_roles.py::test_role_extractor_falls_back_when_activity_detection_fails
/home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine/.venv/lib/python3.12/site-packages/librosa/core/pitch.py:103: UserWarning: Trying to estimate tuning from empty frequency set.
return pitch_tuning(
tests/test_roles.py::test_role_extractor_falls_back_when_activity_detection_fails
/home/runner/work/bandscope/bandscope/pr-head/services/analysis-engine/.venv/lib/python3.12/site-packages/librosa/core/spectrum.py:266: UserWarning: n_fft=2048 is too large for input signal of length=100
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================== 437 passed, 3 warnings in 89.83s (0:01:29) ==================
Name Stmts Miss Cover Missing
------------------------------------------------------------------------------------
src/bandscope_analysis/__init__.py 3 0 100%
src/bandscope_analysis/api.py 571 0 100%
src/bandscope_analysis/chords/__init__.py 5 0 100%
src/bandscope_analysis/chords/analyzer.py 116 0 100%
src/bandscope_analysis/chords/capo.py 10 0 100%
src/bandscope_analysis/chords/chord_recognizer.py 192 0 100%
src/bandscope_analysis/chords/model.py 15 0 100%
src/bandscope_analysis/cli.py 68 0 100%
src/bandscope_analysis/health.py 7 0 100%
src/bandscope_analysis/ranges/__init__.py 4 0 100%
src/bandscope_analysis/ranges/analyzer.py 77 0 100%
src/bandscope_analysis/ranges/model.py 19 0 100%
src/bandscope_analysis/ranges/pitch_tracker.py 54 0 100%
src/bandscope_analysis/roles/__init__.py 4 0 100%
src/bandscope_analysis/roles/activity.py 59 0 100%
src/bandscope_analysis/roles/extractor.py 118 0 100%
src/bandscope_analysis/roles/model.py 58 0 100%
src/bandscope_analysis/roles/priority.py 13 0 100%
src/bandscope_analysis/roles/tuning.py 11 0 100%
src/bandscope_analysis/sections/__init__.py 6 0 100%
src/bandscope_analysis/sections/anchors.py 5 0 100%
src/bandscope_analysis/sections/extractor.py 38 0 100%
src/bandscope_analysis/sections/model.py 35 0 100%
src/bandscope_analysis/sections/segmenter.py 140 0 100%
src/bandscope_analysis/sections/utils.py 8 0 100%
src/bandscope_analysis/separation/__init__.py 4 0 100%
src/bandscope_analysis/separation/audio_separator.py 145 0 100%
src/bandscope_analysis/separation/model.py 31 0 100%
src/bandscope_analysis/separation/separator.py 34 0 100%
src/bandscope_analysis/temporal/__init__.py 3 0 100%
src/bandscope_analysis/temporal/analyzer.py 49 0 100%
src/bandscope_analysis/temporal/model.py 9 0 100%
src/bandscope_analysis/transcription/__init__.py 2 0 100%
src/bandscope_analysis/transcription/api.py 11 0 100%
src/bandscope_analysis/youtube.py 81 0 100%
------------------------------------------------------------------------------------
TOTAL 2005 0 100%
- Result: PASS
Python docstring coverage
- Result: DEFERRED
- Reason: package.json defines check:python-docstrings; repository-owned docstring coverage runs after package dependency setup.
JavaScript/TypeScript dependencies (npm ci)
added 272 packages, and audited 275 packages in 8s
71 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
- Result: PASS
Repository docstring coverage
> [email protected] check:python-docstrings
> sh -c 'cd services/analysis-engine && uv run ruff check src tests ../../scripts --select D100,D101,D102,D103,D104,D105,D106,D107'
All checks passed!
- Result: PASS
JavaScript/TypeScript test coverage
> [email protected] test
> npm run test --workspaces --if-present && sh -c 'cd services/analysis-engine && uv run pytest tests --cov=src/bandscope_analysis --cov-report=term-missing --cov-fail-under=100' --coverage
> @bandscope/[email protected] test
> node -e "require('node:fs').mkdirSync('coverage/.tmp', { recursive: true })" && vitest run --coverage
οΏ½[1mοΏ½[30mοΏ½[46m RUN οΏ½[49mοΏ½[39mοΏ½[22m οΏ½[36mv4.1.9 οΏ½[39mοΏ½[90m/home/runner/work/bandscope/bandscope/pr-head/apps/desktopοΏ½[39m
οΏ½[2mCoverage enabled with οΏ½[22mοΏ½[33mv8οΏ½[39m
οΏ½[32mβοΏ½[39m src/lib/export.test.ts οΏ½[2m(οΏ½[22mοΏ½[2m16 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 19οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/features/workspace/Workspace.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m11 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[33m 1943οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[33mοΏ½[2mβοΏ½[22mοΏ½[39m enables bass transcription from selected role metadata rather than role id text οΏ½[33m 422οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/features/workspace/SectionRoadmap.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m12 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[33m 1109οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[33mοΏ½[2mβοΏ½[22mοΏ½[39m uses localized copy for chord edit prompts and control labels οΏ½[33m 317οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/lib/analysis.test.ts οΏ½[2m(οΏ½[22mοΏ½[2m14 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 18οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[32mβοΏ½[39m src/components/ui/ui-primitives.test.tsx οΏ½[2m(οΏ½[22mοΏ½[2m7 testsοΏ½[22mοΏ½[2m)οΏ½[22mοΏ½[32m 207οΏ½[2mmsοΏ½[22mοΏ½[39m
οΏ½[90mstderrοΏ½[2m | src/App.test.tsxοΏ½[2m > οΏ½[22mοΏ½[2mAppοΏ½[2m > οΏ½[22mοΏ½[2mapplies pushed analysis status updates over the IPC event bridge
οΏ½[22mοΏ½[39mAn update to App inside a test was not wrapped in act(...).
When testing, code that causes React state updates should be wrapped into act(...):
act(() => {
/* fire events that update state */
});
/* assert on the output */
This ensures that you're testing the behavior the user would see in the browser. Learn more at https://react.dev/link/wrap-tests-with-act
## Changed-File Evidence Map
```mermaid
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (21 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (21 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Workflow (13 files)"]
S2 --> I2["GitHub Actions review job"]
I2 --> R2["Review risk: Workflow (13 files)"]
R2 --> V2["actionlint plus required checks"]
Evidence --> S3["Docs (5 files)"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs (5 files)"]
R3 --> V3["docs review"]
Evidence --> S4["CI script (8 files)"]
S4 --> I4["review and security gate shell path"]
I4 --> R4["Review risk: CI script (8 files)"]
R4 --> V4["bash -n plus Strix self-test"]
Evidence --> S5["Test (5 files)"]
S5 --> I5["regression suite"]
I5 --> R5["Review risk: Test (5 files)"]
R5 --> V5["targeted test run"]
|
Closing this as superseded by #536. Reason: this PR contains useful SectionRoadmap interaction-test intent, but later commits carry unrelated required workflow, opencode, package, docs, release, YouTube, and supply-chain changes across 52 files. #536 keeps only the focused |
|
Superseded by #536. |
Pull request was closed
π― What: The SectionRoadmap component lacked full test coverage.
π Coverage: Added tests to cover all functionality, including chord editing handling, song state updating limits, priority icon logic, rendering overlap warnings and confidence badges, role filtering, and disabled state behaviors.
β¨ Result: Test coverage for SectionRoadmap is now 100% across statements, lines, branches, and functions.
PR created automatically by Jules for task 3375919807166646025 started by @seonghobae