Add fixture-backed regression coverage for prior-update behavior and IPD anchor filtering#87
Add fixture-backed regression coverage for prior-update behavior and IPD anchor filtering#87seonghobae with Copilot wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds deterministic, fixture-backed regression coverage to lock down two high-risk autoFIPC() behaviors (prior-distribution update semantics during linking and quantitative IPD/anchor filtering), and updates project docs to reflect the new baseline.
Changes:
- Adds two regression tests that (1) distinguish free-mean vs fixed-normal linking behavior and (2) verify drifted anchors are removed and retained anchors stay fixed on the old-form scale.
- Introduces centralized fixture parameters under
tests/testthat/fixtures/to keep scenarios deterministic and auditable. - Updates
ARCHITECTURE.mdroadmap language and expandsAGENTS.mdwith FIPC literature + algorithmic guardrails.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/testthat/test-regression-fixtures.R | Adds deterministic regression tests for prior-update semantics and IPD anchor filtering assertions. |
| tests/testthat/fixtures/fipc-regression-fixtures.R | Defines reusable fixture parameter sets (seeds, sample sizes, drift index, etc.). |
| ARCHITECTURE.md | Updates roadmap to reflect the new regression-fixture baseline. |
| AGENTS.md | Adds FIPC literature references and development constraints tied to prior-update/IPD behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Superseded by #90. Reason: the markdown failure in this PR is mechanical, but the IPD regression assertion is not safe to repair in place. Current CI showed the synthetic drifted anchor remains in |
Current coverage did not explicitly lock down two high-risk behaviors in
autoFIPC(): prior-distribution update semantics during linking and quantitative IPD/anchor-quality filtering. This PR adds deterministic regression fixtures and targeted assertions for both.Prior-update regression fixture (PARSCALE-vs-BILOG behavior surface)
freeMEAN=TRUE, forceNormalZeroOne=FALSE(mean/cov can move), vsforceNormalZeroOne=TRUE(group mean/cov fixed to0/1).IPD/anchor-quality quantitative regression
checkIPD=TRUEasserting:a1/dvalues in linked calibration.Fixture baseline and roadmap alignment
tests/testthat/fixtures/to centralize scenario parameters.