Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@
^registered_agents\.json$
^task_agent_mapping\.json$
^\.gitleaks\.toml$
^\.jules$
^\.jules/.*
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-07-25 - Prevent redundant expensive operations (mirt::fscores)
**Learning:** In the `aFIPC` package, calculating `mirt::fscores(..., method = 'MAP')` is an expensive operation. Previously, it was called redundantly: once to calculate expected scores (`mirt::expected.test`) and once again to return the `Theta` variables.
**Action:** Always pre-calculate expensive operations like `fscores` and store them in variables to reuse them, avoiding redundant CPU cycles.
16 changes: 8 additions & 8 deletions R/aFIPC.R
Original file line number Diff line number Diff line change
Expand Up @@ -1002,28 +1002,28 @@ autoFIPC <-
# stop('Estimation failed. Please check test quality.')
# }

# calculate theta
ThetaOldform <- fscores(oldFormModel, method = 'MAP')
ThetaLinkedform <- fscores(LinkedModel, method = 'MAP')
ThetaNewform <- fscores(newFormModel, method = 'MAP')

# calculate expected score
ExpectedScoreOldform <-
mirt::expected.test(
x = oldFormModel,
Theta = fscores(oldFormModel, method = 'MAP')
Theta = ThetaOldform
)
ExpectedScoreLinkedform <-
mirt::expected.test(
x = LinkedModel,
Theta = fscores(LinkedModel, method = 'MAP')
Theta = ThetaLinkedform
)
ExpectedScoreNewform <-
mirt::expected.test(
x = newFormModel,
Theta = fscores(newFormModel, method = 'MAP')
Theta = ThetaNewform
)

# calculate theta
ThetaOldform <- fscores(oldFormModel, method = 'MAP')
ThetaLinkedform <- fscores(LinkedModel, method = 'MAP')
ThetaNewform <- fscores(newFormModel, method = 'MAP')

# save results as object
modelReturn <- new.env()
modelReturn$oldFormModel <- oldFormModel
Expand Down
Loading