Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix stack overflow DoS in interactive prompts#71

Open
seonghobae wants to merge 1 commit into
masterfrom
sentinel-fix-dos-637614510425058634
Open

πŸ›‘οΈ Sentinel: [MEDIUM] Fix stack overflow DoS in interactive prompts#71
seonghobae wants to merge 1 commit into
masterfrom
sentinel-fix-dos-637614510425058634

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: checkCorrect, checkoldformBILOGprior, checknewformBILOGprior ν•¨μˆ˜μ—μ„œ 잘λͺ»λœ μž…λ ₯ μ‹œ μž¬κ·€μ μœΌλ‘œ readline()을 ν˜ΈμΆœν•˜μ—¬ μŠ€νƒ μ˜€λ²„ν”Œλ‘œμš°(Denial of Service)λ₯Ό μœ λ°œν•  수 μžˆλŠ” 취약점이 λ°œκ²¬λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
🎯 Impact: μ‚¬μš©μžκ°€ 잘λͺ»λœ μž…λ ₯을 λ°˜λ³΅ν•˜κ±°λ‚˜ λΉ„λŒ€ν™”ν˜• ν™˜κ²½μ—μ„œ EOFκ°€ μ§€μ†μ μœΌλ‘œ μž…λ ₯될 경우 R μ„Έμ…˜μ΄ ν¬λž˜μ‹œλ  수 μžˆμŠ΅λ‹ˆλ‹€.
πŸ”§ Fix: λ¬΄ν•œ μž¬κ·€ ν˜ΈμΆœμ„ while λ£¨ν”„λ‘œ λ³€κ²½ν•˜μ—¬ μ•ˆμ „ν•˜κ²Œ μž…λ ₯을 μ²˜λ¦¬ν•˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
βœ… Verification: ν…ŒμŠ€νŠΈ μŠ€μœ„νŠΈλ₯Ό μ‹€ν–‰ν•˜μ—¬ νšŒκ·€ λ¬Έμ œκ°€ μ—†μŒμ„ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€ (Rscript -e "testthat::test_dir('tests/testthat')").

  • λͺ¨λ“  λ³€κ²½ 사항은 ν•œκ΅­μ–΄λ‘œ μž‘μ„±λ˜μ—ˆμŠ΅λ‹ˆλ‹€.

PR created automatically by Jules for task 637614510425058634 started by @seonghobae

* `checkCorrect`, `checkoldformBILOGprior`, `checknewformBILOGprior`의 μž¬κ·€μ  `readline()` ν˜ΈμΆœμ„ `while` λ£¨ν”„λ‘œ λ³€κ²½
* μ‚¬μš©μžκ°€ 잘λͺ»λœ μž…λ ₯을 반볡적으둜 μ œκ³΅ν•  λ•Œ λ°œμƒν•˜λŠ” C μŠ€νƒ μ˜€λ²„ν”Œλ‘œμš°λ‘œ μΈν•œ μ„Έμ…˜ ν¬λž˜μ‹œ(DoS) λ°©μ§€
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant