-
Notifications
You must be signed in to change notification settings - Fork 0
⚡ Bolt: [성능 개선] 초기 로드 시 불필요한 DOM 업데이트 방지 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seonghobae
wants to merge
4
commits into
main
Choose a base branch
from
bolt-i18n-fast-path-14358998795202841568
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| ## 2024-06-20 - Unnecessary initial DOM updates for default language | ||
| **Learning:** The simple static i18n implementation runs `node.textContent = dict[node.dataset.i18n]` for every translatable node on the initial script load, even when the HTML is already written in the target language (Korean). This creates unnecessary layout/paint operations and blocking time on the main thread for elements that don't need text changes. | ||
| **Action:** Always check if the current value matches the desired value before updating the DOM (`node.textContent !== newText`), and add early exits when setting state to the same value to avoid redundant DOM traversal and writes. | ||
|
|
||
| ## 2024-06-26 - 초기 언어 로드를 위한 빠른 경로(Fast path) 적용 | ||
| **Learning:** 초기 페이지 로드 시 요청된 기본 언어가 이미 렌더링된 HTML과 완벽하게 일치함에도 불구하고, 정적 i18n 구현이 무거운 DOM 쿼리(`querySelectorAll`)와 트리 순회를 실행하고 있었습니다. | ||
| **Action:** 초기 상태가 이미 요청된 상태와 일치하는지 항상 확인해야 합니다. `currentLang`이 null이고 `document.documentElement.lang`이 요청된 언어와 일치할 때 DOM 쿼리를 우회하도록 `setLanguage`에 빠른 종료(early exit)를 추가했으며, 실제 언어 전환이 일어날 때만 노드를 쿼리하도록 지연(lazy) 처리했습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.