Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] noema review gate의 SSRF/LFI μœ„ν—˜ μˆ˜μ • #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 2 commits into
base: main
Choose a base branch
from
+12 βˆ’1
Open

πŸ›‘οΈ Sentinel: [MEDIUM] noema review gate의 SSRF/LFI μœ„ν—˜ μˆ˜μ • #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d846d16
fix(ci): validate URL schemes in noema_review_gate.py to prevent SSRF
seonghobae Jul 4, 2026
08eb4c3
fix(ci): validate URL schemes in noema_review_gate.py to prevent SSRF
seonghobae Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/ci/noema_review_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ def call_llm(repo: str, number: int, pr: dict[str, Any], diff: str, truncated: b
prompt,
],
}
if not (api_url.startswith("http://") or api_url.startswith("https://")):
raise ValueError(f"URL must start with http:// or https://, got: {api_url}")

request = urllib.request.Request(
api_url,
data=json.dumps(payload).encode("utf-8"),
Expand All @@ -304,7 +307,7 @@ def call_llm(repo: str, number: int, pr: dict[str, Any], diff: str, truncated: b
},
method="POST",
)
with urllib.request.urlopen(request, timeout=120) as response:
with urllib.request.urlopen(request, timeout=120) as response: # nosec B310
raw = response.read().decode("utf-8")
data = json.loads(raw)
content = (((data.get("choices") or [{}])[0].get("message") or {}).get("content") or "").strip()
Expand Down
8 changes: 8 additions & 0 deletions tests/test_noema_review_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,3 +305,11 @@ def test_parse_args_and_main(monkeypatch):

with pytest.raises(SystemExit, match="--pr-number must be positive"):
noema.main(["--repo", "owner/repo", "--pr-number", "0"])

def test_call_llm_rejects_unsafe_url_schemes(monkeypatch):
pr = make_pr()
monkeypatch.setenv("NOEMA_LLM_API_URL", "file:///etc/passwd")
monkeypatch.setenv("NOEMA_LLM_API_KEY", "secret")

with pytest.raises(ValueError, match="URL must start with http:// or https://"):
noema.call_llm("owner/repo", 1, pr, "diff", False)
Loading