Skip to content

๐Ÿ›ก๏ธ Sentinel: [CRITICAL] noema_review_gate.py์˜ SSRF ์ทจ์•ฝ์  ์ˆ˜์ • #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 2 commits into
base: main
Choose a base branch
from
+7 โˆ’1
Open

๐Ÿ›ก๏ธ Sentinel: [CRITICAL] noema_review_gate.py์˜ SSRF ์ทจ์•ฝ์  ์ˆ˜์ • #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d3f12f
๐Ÿ›ก๏ธ Sentinel: [CRITICAL] noema_review_gate.py์˜ SSRF ์ทจ์•ฝ์  ์ˆ˜์ •
seonghobae Jul 3, 2026
884c974
Merge branch 'main' into fix-noema-ssrf-vulnerability-110517971014552โ€ฆ
opencode-agent[bot] Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/ci/noema_review_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@ def call_llm(repo: str, number: int, pr: dict[str, Any], diff: str, truncated: b
if not api_url or not api_key:
print("Noema LLM review unavailable: NOEMA_LLM_API_URL or NOEMA_LLM_API_KEY is not configured.")
return None
if not (api_url.startswith("http://") or api_url.startswith("https://")):
raise ValueError(f"Noema LLM review unavailable: NOEMA_LLM_API_URL must start with http:// or https://, got: {api_url}")

prompt = {
"role": "user",
Expand Down Expand Up @@ -304,7 +306,7 @@ def call_llm(repo: str, number: int, pr: dict[str, Any], diff: str, truncated: b
},
method="POST",
)
with urllib.request.urlopen(request, timeout=120) as response:
with urllib.request.urlopen(request, timeout=120) as response: # nosec B310
raw = response.read().decode("utf-8")
data = json.loads(raw)
content = (((data.get("choices") or [{}])[0].get("message") or {}).get("content") or "").strip()
Expand Down
4 changes: 4 additions & 0 deletions tests/test_noema_review_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,10 @@ def fake_urlopen(request, timeout):
with pytest.raises(RuntimeError, match="unsupported decision"):
noema.call_llm("owner/repo", 1, pr, "diff", False)

monkeypatch.setenv("NOEMA_LLM_API_URL", "file:///etc/passwd")
with pytest.raises(ValueError, match="NOEMA_LLM_API_URL must start with http:// or https://"):
noema.call_llm("owner/repo", 1, pr, "diff", False)


def test_format_findings_and_submit_review(monkeypatch):
findings = noema.format_findings(
Expand Down
Loading