fix: treat nested Rust coverage as peer evidence#291
Open
seonghobae wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the central coverage-evidence contract so repositories that change Rust files under nested crates (but have no root Cargo.toml) produce an explicit advisory instead of failing coverage evidence, and updates the gate self-test to assert the new advisory text.
Changes:
- Add a dedicated “nested Rust coverage” advisory section in
coverage-evidenceoutput when Rust changes are detected without a rootCargo.toml. - Stop treating “Rust changes + no root Cargo.toml” as a coverage-evidence failure; require peer repo-local Rust CI/build/security checks instead (documented in output).
- Extend
scripts/ci/test_strix_quick_gate.shassertions to verify the new advisory messaging is present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/opencode-review.yml |
Converts missing-root-Cargo Rust coverage from a failure into an explicit advisory and updates the coverage-evidence flow accordingly. |
scripts/ci/test_strix_quick_gate.sh |
Adds assertions that the workflow includes the new nested Rust advisory text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+621
to
+628
| append_nested_rust_coverage_advisory() { | ||
| append "### Rust test coverage" | ||
| append "" | ||
| append "- Result: PASS" | ||
| append "- Reason: Rust files changed, but no root Cargo.toml coverage contract was found; nested Rust coverage is not measured by this central workflow." | ||
| append "- Required peer evidence: keep repo-local Rust CI/build/security checks required for nested crates." | ||
| append "" | ||
| } |
Comment on lines
+786
to
790
| append_nested_rust_coverage_advisory | ||
| fi | ||
| fi | ||
|
|
||
| if has_changed_tracked_files 'Dockerfile' '*/Dockerfile' 'Dockerfile.*' '*/Dockerfile.*' 'docker-compose.yml' 'docker-compose.yaml' 'compose.yml' 'compose.yaml'; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.tomlas nested-crate coverage advisory instead of failing central coverage-evidence.BandScope queue impact
coverage-evidencefailure class seen on ContextualWisdomLab/bandscope #527 and #528, where Rust files changed under a nested Tauri crate but the repository root has noCargo.toml.Cargo.tomlprojects still runcargo llvm-cov --fail-under-lines 100.Validation
git diff --checkbash -n scripts/ci/test_strix_quick_gate.shpython3 -c 'import pathlib, yaml; yaml.safe_load(pathlib.Path(".github/workflows/opencode-review.yml").read_text()); print("yaml ok")'\n-rg -n "Rust files changed, but no root Cargo.toml was found|Fix: add or point to the Cargo workspace manifest" .github/workflows/opencode-review.yml scripts/ci/test_strix_quick_gate.shreturned no matches\n\n## Note\n- Did not complete the fullscripts/ci/test_strix_quick_gate.shharness locally because its model-fallback scenarios include long CI-oriented waits; this PR updates its assertion coverage for the changed contract.