feat(core): HTTP readiness probe on admin port 3030#17
Open
kkopanidis wants to merge 1 commit into
Open
Conversation
Switch Core readiness and startup probes to admin HTTP /ready on port 3030, keep gRPC liveness, expose admin-http containerPort, and set READY_REQUIRED_MODULES.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Core pods were using the same shallow gRPC probe for both liveness and readiness, so Kubernetes could mark Core ready before Redis or required modules were actually serving.
This chart update aligns Core probes with the deep readiness work in Conduit:
httpGet /readyon port 3030 (admin HTTP)httpGet /readyon port 3030 (enabled by default)containerPort: 3030READY_REQUIRED_MODULEStodatabase,routerwhen router is enabled (database only otherwise)Depends on: ConduitPlatform/Conduit#1505 — merge Conduit first, then this chart.
Test plan
helm templaterenders Core readiness/startup as HTTP/ready:3030and liveness as gRPC:5000Runningbut isNotReadyuntil database + router registerRunning, becomesNotReady, recovers without restart when Redis returnsrouter.enabled=false,READY_REQUIRED_MODULESisdatabaseonlyFollow-up
Router module deep readiness remains out of scope for this change.