Skip to content

Include thermal sensor upper critical threshold - #177

Merged
derrick-dacosta merged 5 commits into
mainfrom
include-temperature-threshold
Jun 30, 2026
Merged

Include thermal sensor upper critical threshold#177
derrick-dacosta merged 5 commits into
mainfrom
include-temperature-threshold

Conversation

@ibrahimkk-moideen

Copy link
Copy Markdown
Collaborator

Sample of what will be added to scrape results:

# HELP redfish_thermal_sensor_threshold_critical Current sensor upper threshold critical reading in Celsius
# TYPE redfish_thermal_sensor_threshold_critical gauge
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="01-Inlet Ambient"} 42
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="02-CPU 1"} 70
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="03-CPU 2"} 70
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="04-P1 DIMM 1-4"} 87
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="05-P1 DIMM 5-8"} 87
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="06-P2 DIMM 1-4"} 87
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="07-P2 DIMM 5-8"} 87
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="08-HD Max"} 60
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="09-Chipset"} 105
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="11-VR P1"} 115
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="12-VR P2"} 115
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="13-VR P1Mem"} 115
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="14-VR P1Mem"} 115
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="15-VR P2Mem"} 115
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="16-VR P2Mem"} 115
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="17-Storage Batt"} 65
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="18-Battery Zone"} 65
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="19-HD Controller"} 100
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="21-PCI Zone"} 80
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="24-PCI 3"} 100
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="26-P/S 1"} 0
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="27-P/S 2"} 0
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="28-P/S 3"} 0
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="29-P/S 4"} 0
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="30-System Board"} 80
redfish_thermal_sensor_threshold_critical{chassisModel="xl450g9",chassisSerialNumber="XXXXXXXXX",name="31-Sys Exhaust"} 80
# HELP redfish_up was the last scrape of fishymetrics successful.
# TYPE redfish_up gauge
redfish_up 1

@ibrahimkk-moideen

Copy link
Copy Markdown
Collaborator Author

Local unit testing:

go test -v ~/git-repos/opensource/fishymetrics/exporter/ -run Test_Exporter_Metrics_Handling/Good_Thermal_Sensor_Threshold_Critical
=== RUN   Test_Exporter_Metrics_Handling
=== RUN   Test_Exporter_Metrics_Handling/Good_Thermal_Sensor_Threshold_Critical
--- PASS: Test_Exporter_Metrics_Handling (0.00s)
    --- PASS: Test_Exporter_Metrics_Handling/Good_Thermal_Sensor_Threshold_Critical (0.00s)
PASS
ok  	github.com/comcast/fishymetrics/exporter	0.394s

@ibrahimkk-moideen ibrahimkk-moideen linked an issue Jun 22, 2026 that may be closed by this pull request
@derrick-dacosta
derrick-dacosta merged commit 3fdcdb8 into main Jun 30, 2026
3 checks passed
@ibrahimkk-moideen
ibrahimkk-moideen deleted the include-temperature-threshold branch July 1, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capture critical threshold in temperature reading

2 participants