Skip to content

[LOGO] zcash - #1369

Open
mahnunchik wants to merge 1 commit into
masterfrom
logo-zcash
Open

[LOGO] zcash#1369
mahnunchik wants to merge 1 commit into
masterfrom
logo-zcash

Conversation

@mahnunchik

@mahnunchik mahnunchik commented Nov 26, 2025

Copy link
Copy Markdown
Collaborator

Note

Overview
Replaces the Zcash icon in logo/zcash.svg and logo-dark/zcash.svg with updated artwork.

The old 65×65 flat gold circle and simple white Z are swapped for a 2500×2500 design: gold linear gradient fill, outer ring, and a more detailed Z mark. Light and dark variants share the same structure; only the gradient id differs so they don’t clash when both are used.

Reviewed by Cursor Bugbot for commit 9d8595a. Bugbot is set up for automated code reviews on this repo. Configure here.

@mahnunchik
mahnunchik force-pushed the logo-zcash branch 7 times, most recently from 8a73e97 to 8743f66 Compare December 3, 2025 05:53
@mahnunchik
mahnunchik force-pushed the logo-zcash branch 8 times, most recently from ebd25b9 to a1d47c1 Compare December 11, 2025 05:53
@mahnunchik
mahnunchik force-pushed the logo-zcash branch 7 times, most recently from 54c2536 to 1ad8c91 Compare December 18, 2025 05:55
@mahnunchik
mahnunchik force-pushed the logo-zcash branch 7 times, most recently from 7380330 to 4d28c10 Compare December 25, 2025 05:53
@mahnunchik
mahnunchik force-pushed the logo-zcash branch 7 times, most recently from c40d151 to dbcd737 Compare January 15, 2026 05:57
@mahnunchik
mahnunchik force-pushed the logo-zcash branch 7 times, most recently from 06b8a7d to 527fe21 Compare January 22, 2026 05:57
@mahnunchik
mahnunchik force-pushed the logo-zcash branch 7 times, most recently from c89547c to 3b3b7ba Compare January 29, 2026 06:00
@mahnunchik
mahnunchik force-pushed the logo-zcash branch 6 times, most recently from fec3a44 to 5965eb9 Compare February 4, 2026 06:03
Comment thread logo/zcash.svg
</defs>
<path fill="url(#logo_zcash_svg__a)" d="M1263.05 2297.61c-569.6 0-1034.57-465.43-1034.57-1034.56 0-569.6 465.44-1034.57 1034.57-1034.57 569.6 0 1034.56 465.44 1034.56 1034.57 0 569.6-464.96 1034.56-1034.56 1034.56"/>
<path d="M1250 2500C562.5 2500 0 1937.5 0 1250S562.5 0 1250 0s1250 562.5 1250 1250-562.5 1250-1250 1250m0-2222.06c-534.56 0-972.06 437.5-972.06 972.06s437.5 972.06 972.06 972.06 972.06-437.5 972.06-972.06-437.5-972.06-972.06-972.06"/>
<path d="M1221.05 1588.59h541.67v270.84h-319.6v229.16h-277.94v-222.06H831.85c0-90.44-13.73-180.4 7.1-263.73 7.1-41.67 55.4-83.34 90.43-125 104.17-125 208.34-250 319.61-375 41.66-48.77 83.33-90.44 132.1-145.83H860.26V686.13h305.39V457h270.84v222h333.33c0 90.43 13.73 180.4-7.1 263.73-7.1 41.67-55.4 83.33-90.44 125-104.16 125-208.33 250-319.6 375-41.68 48.8-83.33 97.09-131.63 145.86"/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Z glyph lost white fill

Medium Severity

The Z letter path no longer sets fill="#fff". It inherits the default black fill, so the glyph no longer matches the prior asset or the official white-on-gold Zcash mark once the ring renders correctly.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 1d67298. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 29c9c0f. Configure here.

Comment thread logo/zcash.svg
</linearGradient>
</defs>
<path fill="url(#logo_zcash_svg__a)" d="M1263.05 2297.61c-569.6 0-1034.57-465.43-1034.57-1034.56 0-569.6 465.44-1034.57 1034.57-1034.57 569.6 0 1034.56 465.44 1034.56 1034.57 0 569.6-464.96 1034.56-1034.56 1034.56"/>
<path d="M1250 2500C562.5 2500 0 1937.5 0 1250S562.5 0 1250 0s1250 562.5 1250 1250-562.5 1250-1250 1250m0-2222.06c-534.56 0-972.06 437.5-972.06 972.06s437.5 972.06 972.06 972.06 972.06-437.5 972.06-972.06-437.5-972.06-972.06-972.06"/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing fill-rule makes ring render as solid disc

High Severity

The ring path on line 9 is a compound shape with two concentric circle subpaths that both wind in the same direction (clockwise). Without fill-rule="evenodd", SVG's default nonzero winding rule fills the inner circle instead of cutting it out as a hole. This causes the path to render as a solid black disc covering the entire viewport, completely hiding the gradient-filled coin beneath it. The Z glyph (also default black) becomes invisible on top. Comparable ring paths in this repo (e.g. illuvium.svg) correctly use fill-rule="evenodd".

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 29c9c0f. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant