Skip to content

Prevent unauthorized access to private charts #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vytisbulkevicius merged 1 commit into from
Jun 30, 2026
+18 −7
Merged

Prevent unauthorized access to private charts #1326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions classes/Visualizer/Module/Frontend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,25 @@ public function endpoint_register() {
),
),
'permission_callback' => function ( WP_REST_Request $request ) {
$chart_id = filter_var( sanitize_text_field( $request->get_param( 'chart' ), FILTER_VALIDATE_INT ) );
if ( ! empty( $chart_id ) && in_array( $request->get_param( 'type' ), array( 'save', 'cancel' ), true ) ) {
// let save and cancel go without any check as past version of pro
// did not send the X-WP-Nonce
// we can change this at a later date.
return true;
$chart_id = absint( $request->get_param( 'chart' ) );
if ( ! $chart_id ) {
return false;
}
return ! empty( $chart_id ) && apply_filters( 'visualizer_pro_show_chart', true, $chart_id );

$chart = get_post( $chart_id );
if ( ! $chart || Visualizer_Plugin::CPT_VISUALIZER !== $chart->post_type ) {
return false;
}

if ( in_array( $request->get_param( 'type' ), array( 'save', 'cancel' ), true ) ) {
return current_user_can( 'edit_post', $chart_id );
}

if ( 'publish' !== $chart->post_status ) {
return current_user_can( 'edit_post', $chart_id );
}

return apply_filters( 'visualizer_pro_show_chart', true, $chart_id );
},
'callback' => array( $this, 'perform_action' ),
)
Expand Down
Loading