Skip to content

feat: per-route metrics, audit events, stellar transfer test, and risk gauge - #1217

Merged
mftee merged 2 commits into
CodeGirlsInc:mainfrom
walexjnr:feat/issues-926-940-944-945
Aug 25, 2026
Merged

feat: per-route metrics, audit events, stellar transfer test, and risk gauge#1217
mftee merged 2 commits into
CodeGirlsInc:mainfrom
walexjnr:feat/issues-926-940-944-945

Conversation

@walexjnr

Copy link
Copy Markdown
Contributor

Summary

Closes #945
Closes #944
Closes #940
Closes #926

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@walexjnr is attempting to deploy a commit to the Mftee's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 25, 2026

Copy link
Copy Markdown

@walexjnr Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mftee mftee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Strong PR:

  • Fixes a genuine pre-existing compile bug in stellar.rs::check_connection (referenced an undefined result variable — this wouldn't have compiled). Good catch.
  • Rewrites verify_hash tests to match the real Horizon manageData account-lookup implementation instead of a stale /transactions?memo= approach the old tests assumed.
  • New per-route request metrics (requests_total_by_route{route=...}, CT-40) wired into verify/submit/revoke/transfer/batch-verify, with isolation tests.
  • New audit-event log (CT-39): record_audit_event appends to a capped cache-backed list, GET /audit reads it back reversed (most recent first), failures are logged and never break the request path — good defensive design for an audit trail.
  • RiskGauge: clean inline-SVG gauge, clamps out-of-range scores, includes an sr-only text equivalent for accessibility, solid test coverage.

Approving.

Resolve conflicts in contract/src/lib.rs between the webhook dispatch
(PR CodeGirlsInc#1216) and the audit-event log (PR CodeGirlsInc#1217): both are additive and
independent, so both calls run at each of the four write sites
(transfer, verify, submit, revoke).
@mftee
mftee merged commit 96f4f4f into CodeGirlsInc:main Aug 25, 2026
2 of 7 checks passed
mftee added a commit to zakariyaufarida5-wq/SMALDA that referenced this pull request Aug 25, 2026
Resolve a trivial conflict in contract/src/stellar.rs: both this PR
and the already-merged CodeGirlsInc#1217 independently made the identical
check_connection fix and test rewrite, so the only real conflict was
a comment-text difference in a section header. Kept the more
descriptive (ticketed) version.
mftee added a commit that referenced this pull request Aug 25, 2026
…-938-939

Merging per repo maintainer review. Trivial conflict in contract/src/stellar.rs resolved: both this PR and the already-merged #1217 independently made the identical check_connection fix, so the only conflict was a comment-text difference. Pre-existing CI failures otherwise predate these PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants