fix(eval): return error for out-of-range slice expression instead of panicking#232
Open
SAY-5 wants to merge 1 commit into
Open
fix(eval): return error for out-of-range slice expression instead of panicking#232SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…panicking Signed-off-by: SAY-5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice expressions like
{{ .[1:10] }}on a shorter slice pass the user-controlled bounds straight intoreflect.Value.Slice, which panics with aruntime.Error("slice index out of bounds"). The runtime recover in(*Runtime).recoverre-panics onruntime.Error, so this crashes the calling application instead of being returned as a normal template error.The index path (
indexArg) already validates bounds and returns an error; this brings slice expressions in line by validatingindex/lengthagainst the base length before callingSlice.Reproduces with
{{ .[1:10] }},{{ .[2:1] }}, and{{ .[-1:1] }}.Added
TestEvalSliceExpressionOutOfRangecovering over-length, reversed, and negative bounds. It panics without the fix and passes with it. Full suite green undergo test -race ./....