Promote incident reports to named advisory subtype#85
Merged
Conversation
Pairs with SecID-Service PR #12 (already merged + deployed) which declared "incident" as a valid subtype value in the canonical type-registry. This PR wires up the SecID side: documentation, registry tagging, and a CLAUDE.md WARNING-block accuracy fix that the audit surfaced. Documentation - docs/reference/TYPES-AND-SUBTYPES.md: new "### advisory" section under "Named subtypes in use today" with the canonical incident subtype row; promotes the row OUT of "Implicit overloads" with a forward-pointer note. - CLAUDE.md SecID Types table: advisory cell updated to reflect the now- tagged status (was "implicit, untagged today"). - CLAUDE.md WARNING block: corrects four inaccuracies surfaced by the audit (src/types.ts -> src/type-registry.ts; missing schemas/registry-namespace enum; missing python/registry_loader.py; client-SDK clarification). Tagging (5 source-level match_nodes across 4 files, no backfill sweep) - registry/advisory/gov/nhtsa.json: SGO match_node only. Recall and ODI match_nodes stay untagged — they are advisories, not incidents. - registry/advisory/org/aiaaic.json: AIAAIC Repository (sole match_node). - registry/advisory/gov/ca/dmv.json: av-collision + av-disengagement; av-permits stays untagged (permit records, not incidents). - registry/advisory/org/partnershiponai.json: AIID (sole match_node). Validation - python3 scripts/validate-subtypes.py: passes (49 subtype usages across 12 distinct (type, value) pairs; advisory + incident is one of them). - All four modified JSON files parse cleanly. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires up the `advisory + ["incident"]` subtype on the SecID side after SecID-Service PR #12 declared the value in the canonical `type-registry.ts`. Bundles a CLAUDE.md WARNING-block accuracy fix surfaced by the audit that preceded this work.
Changes
Documentation:
Registry tagging (5 source-level match_nodes across 4 files; no backfill sweep):
Test plan
Out of scope
🤖 Generated with Claude Code